Skip to content

Accept fd as a keyword in epoll.unregister #9553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Nov 3, 2026
Merged

Accept fd as a keyword in epoll.unregister #9553

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bdc028
Accept fd as a keyword in epoll.unregister
youknowdot Nov 2, 2026
51651bb
Remove epoll unregister metadata test per review
youknowdot Nov 3, 2026
1d3e01d
Merge main into epoll unregister keyword fix
youknowdot Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion crates/stdlib/src/select.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,12 @@ mod decl {
}
}

#[derive(FromArgs)]

@chatgpt-codex-connector chatgpt-codex-connector Bot Nov 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required AI-assistance trailers

This AI-authored commit identifies Codex as its author/committer and includes CodeRabbit-generated content, but its commit message contains no Assisted-by: AGENT_NAME:MODEL_VERSION trailer. Add one trailer for each AI tool used before merging so the commit complies with the repository's mandatory AI-disclosure policy.

AGENTS.md reference: AGENTS.md:L20-L23

Useful? React with 👍 / 👎.

struct EpollUnregisterArgs {
#[pyarg(any)]
fd: PyObjectRef,
}

#[derive(FromArgs)]
struct EpollModifyArgs {
#[pyarg(any)]
Expand Down Expand Up @@ -631,7 +637,13 @@ mod decl {
}

#[pymethod]
fn unregister(zelf: &Py<Self>, fd: Fildes, vm: &VirtualMachine) -> PyResult<()> {
fn unregister(
zelf: &Py<Self>,
args: EpollUnregisterArgs,
vm: &VirtualMachine,
) -> PyResult<()> {
// Validate the argument shape before fileno() can run Python code.
let fd = Fildes::try_from_object(vm, args.fd)?;
let epoll_fd = &*zelf.get_epoll(vm)?;
host_select::epoll::delete(epoll_fd, fd.as_raw_fd())
.map_err(|e| e.into_pyexception(vm))
Expand Down
Loading