Skip to content

Expose Clinic defaults for grapheme iteration and reduce #9540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 5 commits into from
Nov 3, 2026
Merged

Expose Clinic defaults for grapheme iteration and reduce #9540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1998141
Expose Clinic defaults for grapheme iteration and reduce
youknowdot Nov 2, 2026
8e1c05d
Print existing signature mismatch details in CI
youknowdot Nov 2, 2026
e16188e
Derive grapheme start default from its argument value
youknowdot Nov 3, 2026
edb653b
Keep grapheme start default on its native omission path
youknowdot Nov 3, 2026
47be90b
Remove Rust-only checks for Python callable signatures
youknowdot Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@ jobs:

- name: Check whats_left is not broken
shell: bash
run: python -I scripts/whats_left.py --rustpython target/release/rustpython
run: python -I scripts/whats_left.py --signature --rustpython target/release/rustpython

clippy:
# Named after the matrix entry rather than left to be named for it: a
Expand Down
13 changes: 11 additions & 2 deletions crates/stdlib/src/unicodedata.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,13 +223,22 @@ mod unicodedata {
}
}

#[pyfunction]
fn iter_graphemes(
#[derive(FromArgs)]
struct IterGraphemesArgs {
#[pyarg(positional)]
unistr: PyStrRef,
#[pyarg(positional, optional, py_default = "0")]
start: OptionalArg<PyObjectRef>,
#[pyarg(positional, optional, py_default = "sys.maxsize")]
end: OptionalArg<PyObjectRef>,
}

#[pyfunction]
fn iter_graphemes(
args: IterGraphemesArgs,
vm: &VirtualMachine,
) -> PyResult<crate::vm::PyRef<GraphemeBreakIterator>> {
let IterGraphemesArgs { unistr, start, end } = args;
// Convert in argument order, including overflow, before adjusting bounds.
let index = |arg: OptionalArg<PyObjectRef>, default| -> PyResult<isize> {
match arg {
Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/stdlib/_functools.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ mod _functools {
function: PyObjectRef,
#[pyarg(positional)]
iterable: PyIter,
#[pyarg(any, optional)]
#[pyarg(any, optional, py_default = "functools._initial_missing")]
initial: OptionalOption<PyObjectRef>,
}

Expand Down
Loading