Repository navigation
Align core callable signatures and argument contracts - #9538
youknowone merged 6 commits into
Conversation
Preserve Clinic display defaults without collapsing omitted arguments. Match JSON truth conversion, lazy setter keywords, and lock exit arity. Assisted-by: OpenAI Codex:model version not exposed
Assisted-by: OpenAI Codex:model version not exposed
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
Assisted-by: OpenAI Codex:model version not exposed
| #[pyarg(any)] | ||
| name: PyObjectRef, | ||
| #[pyarg(any, optional)] | ||
| #[pyarg(any, optional, py_default = "None")] |
There was a problem hiding this comment.
if default is required, isn't it betterto model it as Option and default = None?
Assisted-by: OpenAI Codex:model version not exposed
Merging this PR will not alter performance
Comparing Footnotes
|
Preserve pointer-width warning stack levels alongside signature defaults. Assisted-by: OpenAI Codex:model version not exposed
Category and source already treat omitted and explicit None identically. Represent that contract with Option and a typed default instead of text-only signature overrides. Assisted-by: OpenAI Codex:model version not exposed
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Scope
Follow up 15 concrete signature mismatches in the existing
whats_leftCI report against CPython 3.15.0. This is not a claim that the full signature inventory is fixed.__lazy_import__and_warnings.warn.scanstringits actual positional/default metadata and use truth conversion forstrict(the prior Rust bool converter only accepted integers).syslazy-import setters.__exit__before releasing, rather than accepting arbitrary varargs.--signatureoutput option on the existing CI comparison command; it only prints details the script already computes, without adding scans/imports.Two pure Rust tests check the actual warning/lazy-import parameter metadata. No Lib tests, assertions, snippets, dependencies or generic binder ordering are changed.
Validation
d220409a13b77de7a6c30abe16ea90db01528edc: passed.Remaining differences include warning stacklevel's i32 width vs Py_ssize_t and generic invalid-call error priority. This patch does not establish complete runtime or error-message parity.