Repository navigation
Fix signature header boundaries and exponent rendering - #9531
Merged
youknowone merged 3 commits intoNov 2, 2026
Merged
youknowone merged 3 commits into
youknowone merged 3 commits into
Conversation
Match CPython skip_signature header boundaries for both signature exposure and doc stripping. Add pure string tests for malformed headers and valid multiline boundaries. Assisted-by: OpenAI Codex:model version not exposed
Reuse integer rendering after the exponent sign and minimum two-digit padding. Test decimal exponent boundaries and sizing pass. This does not make the existing float normalization algorithm shortest-round-trip. Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Keep the same short-circuit header validation and document slice; address the exact collapsible_if failure from Linux Clippy and the WASM check without lint suppression. Assisted-by: OpenAI Codex:model version not exposed
youknowone
approved these changes
Nov 2, 2026
youknowone
marked this pull request as ready for review
November 2, 2026 15:23
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two independent string-processing defects in the shared text-signature machinery:
skip_signature. Documentation stripping uses the same boundary check, so malformed headers retain their original docs.The commits add pure string/formatting unit tests only. They do not construct a VM, change argument binding, alter method-flag semantics, or change Lib tests.
Evidence and scope
The header contract is grounded in CPython 3.15
Objects/typeobject.c.The exponent bug follows directly from emitting
b'0' + exp / 10as one byte whenexp >= 100. Tests cover signed and unsigned one-, two-, and three-digit exponent boundaries and the sizing pass.These are generic API defects discovered during the
whats_leftinvestigation, not yet identified as causes of a specific reported mismatch. This PR is independent of the report-only #9530. It does not implement CPython's method-flag signature fallback or claim full shortest-round-trip float rendering; the existing inaccurate comment about that guarantee is corrected.Validation
git diff --check: passed.