Repository navigation
Preserve raw mappingproxy rich-comparison results - #9039
Merged
youknowone merged 1 commit intoOct 10, 2026
Merged
Conversation
Extract the Python 3.14 comparison contract from RustPython#8954 without its 3.15 ordering restrictions or defensive copies. Return the wrapped mapping comparison result without truth conversion. Cover all six direct and reflected operations in the existing mappingproxy snippet. Assisted-by: OpenAI Codex:model identifier unavailable
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
youknowone
approved these changes
Oct 10, 2026
youknowone
marked this pull request as ready for review
October 10, 2026 10:33
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return the wrapped mapping's rich-comparison result without converting it to bool. This preserves arbitrary result objects for all six mappingproxy comparisons, as in CPython 3.14.
Extracted from #8954 without its Python 3.15 ordering restrictions, defensive copies, or frozendict dependencies. The existing mappingproxy snippet covers direct and reflected comparisons, result identity, and unwanted truth conversion.
Validation:
__bool__.AI-assisted implementation, tests, and review with OpenAI Codex. Kept as a draft for CI and maintainer review.