Skip to content

Drop gc_traversal from CodSpeed benches - #8750

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowone:drop-gc-traversal-bench
Sep 20, 2026
Merged

Drop gc_traversal from CodSpeed benches#8750
youknowone merged 1 commit into
RustPython:mainfrom
youknowone:drop-gc-traversal-bench

Conversation

@youknowone

@youknowone youknowone commented Sep 20, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member
  • Closes #xxxx

One of checkbox below must be checked.

  • I did not use AI to write the code of this patch.
  • This PR follows our AI policy

Summary

Remove benches/benchmarks/gc_traversal.py so CodSpeed no longer includes that execution benchmark. Also drop it from PYPERFORMANCE_BENCHMARKS in tests/benchmark_scripts.rs.

Same approach as dropping gc_collect.py in #8731.

Summary by CodeRabbit

  • Chores
    • Removed the garbage-collection traversal benchmark.
    • Benchmark runs no longer include this test; all other benchmark coverage remains unchanged.

@youknowone
Drop gc_traversal from CodSpeed benches
19fe194 
Remove benches/benchmarks/gc_traversal.py so CodSpeed no longer
includes that execution benchmark.

Assisted-by: Grok:4.6
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 20, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Sep 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: RustPython/RustPython/.coderabbit.yml

Review profile: CHILL

Plan: Advanced

Run ID: 9dddc243-19d2-4008-82a1-77d594157c4b

📥 Commits

Reviewing files that changed from the base of the PR and between 2006c63 and 19fe194.

📒 Files selected for processing (2)
  • benches/benchmarks/gc_traversal.py
  • tests/benchmark_scripts.rs
💤 Files with no reviewable changes (2)
  • tests/benchmark_scripts.rs
  • benches/benchmarks/gc_traversal.py

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

The pull request removes the gc_traversal.py benchmark and removes its entry from the PYPERFORMANCE_BENCHMARKS list.

Changes

Benchmark removal

Layer / File(s) Summary
Remove GC traversal benchmark
benches/benchmarks/gc_traversal.py, tests/benchmark_scripts.rs		 The recursive garbage-collection benchmark was deleted. Its entry was removed from the Rust benchmark list.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: removing the gc_traversal benchmark from CodSpeed benches.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@youknowone
youknowone merged commit 4cc7559 into RustPython:main Sep 20, 2026
9 checks passed
@youknowone
youknowone deleted the drop-gc-traversal-bench branch September 20, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moreal moreal Awaiting requested review from moreal
@fanninpm fanninpm Awaiting requested review from fanninpm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@youknowone