Clean up deprecations by lsahn-gh · Pull Request #8300 · RustPython/RustPython

lsahn-gh · 2026-07-17T04:46:16Z

Closes Fix deprecated constant and method usage in host_env and vm crates. #8297
This PR follows our AI policy

Summary

This PR has two commits that replace the deprecated methods in libc with new APIs or define a new const value due to compatibility.

Summary by CodeRabbit

Bug Fixes
- Improved stability when tracking function versions at runtime by adjusting how the internal version counter is atomically updated.
- Improved reliability when updating collection-related type flags, including correct propagation through subclass hierarchies.
- Ensured Android-specific resource limit constant availability by defining the exported constant explicitly for consistent cross-environment behavior.

coderabbitai · 2026-07-17T04:48:05Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: ae6f2e6f-f900-40e5-896c-e39f925fe3d7

📥 Commits

Reviewing files that changed from the base of the PR and between 50939de and 4925517.

📒 Files selected for processing (3)

crates/host_env/src/resource.rs
crates/vm/src/builtins/function.rs
crates/vm/src/builtins/type.rs

🚧 Files skipped from review as they are similar to previous changes (2)

crates/host_env/src/resource.rs
crates/vm/src/builtins/function.rs

📝 Walkthrough

Walkthrough

The changes replace the deprecated Android RLIM_NLIMITS re-export and two VM fetch_update calls while preserving existing update and subclass-recursion behavior.

Changes

Deprecation cleanup

Layer / File(s)	Summary
Android resource-limit constant `crates/host_env/src/resource.rs`	Android now defines `RLIM_NLIMITS` locally as a `libc::c_int` constant with value `16`.
VM atomic update calls `crates/vm/src/builtins/function.rs`, `crates/vm/src/builtins/type.rs`	VM version and ABC collection-flag updates now use `try_update` instead of `fetch_update`, retaining existing update and propagation behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

RustPython/RustPython#7932: Modifies the overlapping Android RLIM_NLIMITS definition in host_env.

Suggested reviewers: youknowone, shaharnaveh

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and accurately reflects the deprecation cleanup across libc and atomic APIs.
Linked Issues check	✅ Passed	The PR updates the deprecated libc constant and replaces both fetch_update calls with try_update as requested.
Out of Scope Changes check	✅ Passed	The changes stay focused on the deprecated constant and method replacements, with no obvious unrelated scope added.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@crates/host_env/src/resource.rs`:
- Around line 36-37: Update the Android-only RLIM_NLIMITS constant in
resource.rs to use libc::c_int, matching libc::RLIM_NLIMITS and the type
expected by crates/stdlib/src/resource.rs; leave its value and other platform
definitions unchanged.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 9f309701-c2aa-4bac-959c-2239e0587e44

📥 Commits

Reviewing files that changed from the base of the PR and between 1205fd2 and 820fb4a.

📒 Files selected for processing (3)

crates/host_env/src/resource.rs
crates/vm/src/builtins/function.rs
crates/vm/src/builtins/type.rs

fetch_update() in atomic namespace is in the deprecation stage.

Define a new const, RLIM_NLIMITS instead of libc::RLIM_NLIMITS in order to clean up the deprecated const and to prevent breaking API where the const is still used.

ShaharNaveh

tysm!

moreal

Thank you!

Refs

https://docs.rs/libc/latest/aarch64-linux-android/libc/constant.RLIM_NLIMITS.html

👎Deprecated since 0.2.64:
Not stable across OS versions

https://github.com/python/cpython/blob/323c59a5e348347be2ce2b7ea55fcb30bf68b2d3/Doc/data/python3.14.abi#L2217-L2218

https://doc.rust-lang.org/std/sync/atomic/type.AtomicU64.html#method.fetch_update

👎Deprecating in 1.99.0:
renamed to try_update for consistency

lsahn-gh force-pushed the clean-up-deprecations branch 2 times, most recently from 592a6bd to 23d0d5e Compare July 17, 2026 04:51

coderabbitai Bot reviewed Jul 17, 2026

View reviewed changes

Comment thread crates/host_env/src/resource.rs Outdated

lsahn-gh force-pushed the clean-up-deprecations branch from 23d0d5e to 50939de Compare July 17, 2026 05:07

lsahn-gh added 2 commits July 17, 2026 14:28

vm: replace fetch_update() with try_update()

5dbb880

fetch_update() in atomic namespace is in the deprecation stage.

host_env: replace libc::RLIM_NLIMITS with const RLIM_NLIMITS

4925517

Define a new const, RLIM_NLIMITS instead of libc::RLIM_NLIMITS in order to clean up the deprecated const and to prevent breaking API where the const is still used.

lsahn-gh force-pushed the clean-up-deprecations branch from 50939de to 4925517 Compare July 17, 2026 05:30

moreal added the z-ca-2026 Tag to track Contribution Academy 2026 label Jul 17, 2026

ShaharNaveh approved these changes Jul 18, 2026

View reviewed changes

moreal approved these changes Jul 18, 2026

View reviewed changes

youknowone merged commit b838989 into RustPython:main Jul 18, 2026
26 checks passed

lsahn-gh deleted the clean-up-deprecations branch July 19, 2026 05:31

Navigation Menu

Uh oh!

Clean up deprecations - #8300

Clean up deprecations#8300
youknowone merged 2 commits into
RustPython:mainfrom
lsahn-gh:clean-up-deprecations

lsahn-gh commented Jul 17, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

ShaharNaveh left a comment

Uh oh!

moreal left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

lsahn-gh commented Jul 17, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ShaharNaveh left a comment

Choose a reason for hiding this comment

Uh oh!

moreal left a comment

Choose a reason for hiding this comment

Refs

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lsahn-gh commented Jul 17, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading