Skip to content

Bump unicode_names2 and rustls-graviola - #8203

Merged
youknowone merged 1 commit into
RustPython:mainfrom
joshuamegnauth54:bump-graviola-unicode_names
Jul 2, 2026
Merged

Bump unicode_names2 and rustls-graviola#8203
youknowone merged 1 commit into
RustPython:mainfrom
joshuamegnauth54:bump-graviola-unicode_names

Conversation

@joshuamegnauth54

@joshuamegnauth54 joshuamegnauth54 commented Jul 1, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

  • I bumped unicode_names2 from 2.x.x to 3. This matches RustPython's Unicode version now.

Summary by CodeRabbit

  • Chores

    • Updated workspace dependency versions for improved compatibility and maintenance.

  • Developer Experience

    • Adjusted example build settings so the related TLS provider is treated as a development dependency rather than an optional feature.
    • Updated the custom_tls_providers example requirements accordingly.

  • User Impact

    • No user-facing behavior or configuration changes.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: f23ec9cd-c2fb-4d08-ab72-8f5bf4615ae0

📥 Commits

Reviewing files that changed from the base of the PR and between f8e8293 and 66027cf.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml
📝 Walkthrough

Walkthrough

This PR moves rustls-graviola from normal dependencies to dev-dependencies, updates the custom_tls_providers example feature gating, and bumps workspace versions for rustls-graviola and unicode_names2.

Changes

Cargo.toml dependency updates

Layer / File(s) Summary
Dependency placement, example gating, and workspace version bumps
Cargo.toml		 Moves rustls-graviola out of [dependencies], adds it to [dev-dependencies], removes it from custom_tls_providers required features, and updates the workspace versions for rustls-graviola and unicode_names2.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

Two versions lift, one feature falls,
Cargo.toml answers the calls.
A dev-dep shift, a feature trim,
Version lines grow new and slim.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: bumping the unicode_names2 and rustls-graviola dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

ShaharNaveh
ShaharNaveh approved these changes Jul 1, 2026
View reviewed changes

@ShaharNaveh ShaharNaveh left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

can you please check cargo-shearcomment? (not a blocker for this PR)

misplaced optional dependency rustls-graviola (remove the optional flag and move to [dev-dependencies])

@joshuamegnauth54
joshuamegnauth54 force-pushed the bump-graviola-unicode_names branch from f8e8293 to 66027cf Compare July 1, 2026 19:16
@joshuamegnauth54

joshuamegnauth54 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Fixed and force pushed. 😁

@youknowone
youknowone merged commit e1ef518 into RustPython:main Jul 2, 2026
49 of 50 checks passed
@joshuamegnauth54
joshuamegnauth54 deleted the bump-graviola-unicode_names branch July 2, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes
@ShaharNaveh ShaharNaveh ShaharNaveh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshuamegnauth54 @youknowone @ShaharNaveh