Add more abstract functions to c-api by bschoenmaeckers · Pull Request #8202 · RustPython/RustPython

bschoenmaeckers · 2026-06-30T17:58:59Z

Summary by CodeRabbit

New Features
- Expanded C API support for invoking Python callables, including no-argument calls and vectorcall-style dispatch with keyword arguments.
- Added C API helpers to delete mapping items by UTF-8 string keys and to format objects (with optional format specifier).
- Exposed object length and runtime type via new C API entry points.
Bug Fixes
- Improved item deletion when provided UTF-8 keys are invalid by surfacing decoding errors instead of failing silently.

coderabbitai · 2026-06-30T17:59:33Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: e1152a86-3def-407f-a7d4-a788608e2884

📥 Commits

Reviewing files that changed from the base of the PR and between 71d44f0 and 3301c67.

📒 Files selected for processing (1)

crates/capi/src/abstract_.rs

🚧 Files skipped from review as they are similar to previous changes (1)

crates/capi/src/abstract_.rs

📝 Walkthrough

Walkthrough

Six new C-ABI exports are added in crates/capi/src/abstract_.rs for callable dispatch, UTF-8 key deletion, formatting, length, and type access. The file also adds C-string handling imports.

Changes

C-ABI abstract protocol exports

Layer / File(s)	Summary
FFI imports and call wrappers `crates/capi/src/abstract_.rs`	Adds `CStr` and `c_char` imports, and implements `PyObject_CallObject` plus `PyVectorcall_Call` for callable dispatch from the C-ABI.
DelItemString, Format, Length, and Type exports `crates/capi/src/abstract_.rs`	Adds `PyObject_DelItemString`, `PyObject_Format`, `PyObject_Length`, and `PyObject_Type` exports.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

RustPython/RustPython#7937: Both PRs extend crates/capi/src/abstract_.rs with new C-ABI function wrappers for invoking Python callables.
RustPython/RustPython#8035: Both PRs modify crates/capi/src/abstract_.rs to shape the PyObject_Size C-ABI surface, including a direct PyObject_Length wrapper.
RustPython/RustPython#7882: Also extends crates/capi/src/abstract_.rs with new PyObject_* C-ABI protocol wrappers.

Suggested reviewers: ShaharNaveh, youknowone

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding more abstract C-API functions.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@crates/capi/src/abstract_.rs`:
- Around line 191-199: PyObject_Format currently dereferences format_spec
unconditionally, which crashes when callers pass NULL. Update the
PyObject_Format function to detect a null format_spec and treat it as an empty
PyStr before calling try_downcast_ref::<PyStr>(vm), while leaving the obj
handling and vm.format call unchanged.
- Around line 139-147: PyVectorcall_Call is currently routed through
PyObject_Call, which bypasses the vectorcall fast path and can recurse when used
as the callable’s call bridge. Update PyVectorcall_Call in abstract_.rs to
dispatch via the vectorcall entrypoint instead of the normal call slot, using
the existing vectorcall-related helpers/types in this module so the tp_call
bridge preserves vectorcall behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: fc3c192e-d650-46b7-b380-4fa319477111

📥 Commits

Reviewing files that changed from the base of the PR and between 33c0cf7 and 662e26b.

📒 Files selected for processing (1)

crates/capi/src/abstract_.rs

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@crates/capi/src/abstract_.rs`:
- Around line 225-228: In PyObject_Format within abstract_.rs, the current
try_downcast_ref::<PyStr> path returns a generic downcast error for non-string
format_spec values, but this C API should map that case to SystemError to match
CPython. Update the handling around format_spec.as_ref() so non-str specs are
explicitly translated into a SystemError before continuing, while keeping the
existing empty_str fallback for None.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 273e1473-5959-4bf5-9667-93d87a2fb932

📥 Commits

Reviewing files that changed from the base of the PR and between 662e26b and 4c4cc0d.

📒 Files selected for processing (1)

crates/capi/src/abstract_.rs

coderabbitai Bot reviewed Jun 30, 2026

View reviewed changes

Comment thread crates/capi/src/abstract_.rs

Comment thread crates/capi/src/abstract_.rs Outdated

coderabbitai Bot reviewed Jun 30, 2026

View reviewed changes

Comment thread crates/capi/src/abstract_.rs

bschoenmaeckers force-pushed the c-api-more-abstract branch from 4c4cc0d to 71d44f0 Compare July 3, 2026 07:19

youknowone approved these changes Jul 4, 2026

View reviewed changes

bschoenmaeckers added 2 commits July 5, 2026 19:38

Add more abstract functions to c-api

6037e43

Review

3301c67

bschoenmaeckers force-pushed the c-api-more-abstract branch from 71d44f0 to 3301c67 Compare July 5, 2026 17:38

youknowone merged commit 3f9d80b into RustPython:main Jul 6, 2026
26 checks passed

bschoenmaeckers deleted the c-api-more-abstract branch July 6, 2026 11:51

coderabbitai Bot mentioned this pull request Jul 13, 2026

Add more dict functions to c-api #8269

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add more abstract functions to c-api#8202

Add more abstract functions to c-api#8202
youknowone merged 2 commits into
RustPython:mainfrom
bschoenmaeckers:c-api-more-abstract

bschoenmaeckers commented Jun 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 30, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

bschoenmaeckers commented Jun 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bschoenmaeckers commented Jun 30, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 30, 2026 •

edited

Loading