Add more int functions to the c-api#8159
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughExpanded the PyLong C-API with new constructors and extractors, extended integer FfiResult outputs, and changed PyInt unsigned mask handling. ChangesPyLong C-API expansion
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bschoenmaeckers
force-pushed
the
c-api-more-long
branch
5 times, most recently
from
June 25, 2026 11:30
6aa3a82 to
3d85bb2
Compare
Contributor
Author
|
@coderabbitai resume |
Contributor
✅ Action performedReviews resumed. |
bschoenmaeckers
force-pushed
the
c-api-more-long
branch
from
June 25, 2026 11:33
3d85bb2 to
2a94827
Compare
youknowone
reviewed
Jun 25, 2026
| #[must_use] | ||
| pub fn as_u64_mask(&self) -> u64 { | ||
| let v = self.as_bigint(); | ||
| v.to_u64() |
Member
There was a problem hiding this comment.
I didn't investigate the detail yet, but trying to_u64 looks like redundant operation if the fallback still use the last digits
Contributor
Author
There was a problem hiding this comment.
Agreed. Looking at the simplified logic this feels redundant.
Contributor
Author
There was a problem hiding this comment.
I've also applied this to the u32 function
bschoenmaeckers
force-pushed
the
c-api-more-long
branch
from
June 25, 2026 15:23
acec52f to
b8835a8
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/capi/src/longobject.rs`:
- Around line 92-106: The flag parsing in
AsNativeBytesFlags::from_bits_or_default currently accepts the reserved endian
value 2 because it passes through AsNativeBytesFlags::from_bits; add an explicit
rejection for that raw flag before the generic bitmask check so
PyLong_FromNativeBytes and PyLong_FromUnsignedNativeBytes raise ValueError for 2
while still preserving the existing default behavior for -1. Keep the Default
implementation unchanged, since Self::NATIVE_ENDIAN | Self::UNSIGNED_BUFFER is
correct, and ensure the new validation is localized to from_bits_or_default so
both call sites inherit it automatically.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: e0d68fea-f4dd-4ac0-9ab6-740c9eee9e6b
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
crates/capi/Cargo.tomlcrates/capi/src/longobject.rs
bschoenmaeckers
force-pushed
the
c-api-more-long
branch
from
June 26, 2026 07:29
4cf4334 to
ad92c2c
Compare
Contributor
Author
|
@coderabbitai resume |
Contributor
✅ Action performedReviews resumed. |
bschoenmaeckers
force-pushed
the
c-api-more-long
branch
2 times, most recently
from
June 26, 2026 07:40
2bffd0c to
18e54a6
Compare
bschoenmaeckers
force-pushed
the
c-api-more-long
branch
from
June 29, 2026 11:04
18e54a6 to
4ad78c4
Compare
bschoenmaeckers
force-pushed
the
c-api-more-long
branch
from
June 29, 2026 11:59
4ad78c4 to
18f4929
Compare
youknowone
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
PyLong_From*constructors for doubles, signed/unsigned 32- and 64-bit values, native-endian byte buffers, C strings (optional end-pointer), andvoid*/pointer-sized values.PyLong_As*conversions (typed signed/unsigned, size types, and mask variants), replacingPyLong_AsLong.