Skip to content

Add more number functions to c-api#8158

Merged
youknowone merged 1 commit into
RustPython:mainfrom
bschoenmaeckers:c-api-more-number
Jun 25, 2026
Merged

Add more number functions to c-api#8158
youknowone merged 1 commit into
RustPython:mainfrom
bschoenmaeckers:c-api-more-number

Conversation

@bschoenmaeckers

@bschoenmaeckers bschoenmaeckers commented Jun 24, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Expanded numeric C-API support with additional newly exported operations for arithmetic, bitwise logic, negation/absolute/inversion, division, power, remainder, and matrix multiplication.
    • Added a comprehensive set of in-place numeric operation exports (including in-place bit shifts and power) for update-style calculations.
    • Introduced enhanced numeric/index checking and conversion helpers (e.g., float/long) to improve C-API interoperability.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: a57e4cf9-e592-4feb-b133-75fabfbbde93

📥 Commits

Reviewing files that changed from the base of the PR and between 98b64de and 0822ca9.

📒 Files selected for processing (1)
  • crates/capi/src/abstract_/number.rs
🚧 Files skipped from review as they are similar to previous changes (1)
  • crates/capi/src/abstract_/number.rs
📝 Walkthrough

Walkthrough

crates/capi/src/abstract_/number.rs adds C-API wrappers for numeric checks, conversions, standard arithmetic and bitwise operations, and in-place numeric operations, all forwarding into the RustPython VM PyNumber protocol.

Changes

PyNumber C-API wrapper expansion

Layer / File(s) Summary
Imports, checks, and conversion wrappers
crates/capi/src/abstract_/number.rs		 Adds c_int and PyNumber protocol imports; exports PyIndex_Check, PyNumber_Check, PyNumber_Float, PyNumber_Long, and retained PyNumber_Index, all delegating to VM check/conversion methods.
Standard numeric wrappers
crates/capi/src/abstract_/number.rs		 Exports PyNumber_Add, PyNumber_Absolute, PyNumber_Divmod, PyNumber_FloorDivide, PyNumber_Invert, PyNumber_MatrixMultiply, PyNumber_Multiply, PyNumber_Negative, PyNumber_Positive, PyNumber_Power, PyNumber_Remainder, PyNumber_TrueDivide, and PyNumber_Xor, each delegating to the corresponding PyNumber VM method.
In-place numeric wrappers
crates/capi/src/abstract_/number.rs		 Exports PyNumber_InPlaceAdd, PyNumber_InPlaceAnd, PyNumber_InPlaceFloorDivide, PyNumber_InPlaceLshift, PyNumber_InPlaceMatrixMultiply, PyNumber_InPlaceMultiply, PyNumber_InPlaceOr, PyNumber_InPlacePower, PyNumber_InPlaceRemainder, PyNumber_InPlaceRshift, PyNumber_InPlaceSubtract, PyNumber_InPlaceTrueDivide, and PyNumber_InPlaceXor, each delegating to the _i* VM method.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • ShaharNaveh
  • youknowone

Poem

🐇 Hop, hop, the numbers now flow,
Checks and conversions put on a show.
Add, mul, xor, and powers in place,
The VM hums along at a steady pace.
A rabbit applauds with twitchy delight,
For C-API wrappers now leap just right.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: additional numeric C-API functions were added.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@youknowone
youknowone merged commit 6938f36 into RustPython:main Jun 25, 2026
26 checks passed
@bschoenmaeckers
bschoenmaeckers deleted the c-api-more-number branch June 25, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bschoenmaeckers @youknowone