Skip to content

Move some of free standing functions to be ir::Blocks method - #8154

Merged
youknowone merged 16 commits into
RustPython:mainfrom
ShaharNaveh:blocks-methods
Jun 23, 2026
Merged

Move some of free standing functions to be ir::Blocks method#8154
youknowone merged 16 commits into
RustPython:mainfrom
ShaharNaveh:blocks-methods

Conversation

@ShaharNaveh

Copy link
Copy Markdown
Contributor

Summary

This is some of the possible cleanup, I've decided to do it in chunks because the diff is already pretty big and there's a lot more that can be done

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)
  • crates/codegen/src/ir.rs
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: bbfd214c-5dad-40b8-b0b4-ab935f64654a

📥 Commits

Reviewing files that changed from the base of the PR and between 18dc6b3 and 887a64d.

📒 Files selected for processing (1)
  • crates/codegen/src/ir.rs

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to see this change

@youknowone
youknowone merged commit 8905b80 into RustPython:main Jun 23, 2026
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants