Skip to content

Don't skip test in test_tempfile.py #8067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ShaharNaveh wants to merge 4 commits into
base: main
Choose a base branch
from
+3 −1
Draft

Don't skip test in test_tempfile.py #8067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
704b1fe
Don't skip test in `test_tempfile.py`
ShaharNaveh Jun 9, 2026
e686424
Merge remote-tracking branch 'upstream/main' into no-skip-tempfile-test
ShaharNaveh Jun 10, 2026
8ea764a
Apply @fanninpm suggestion
ShaharNaveh Jun 10, 2026
3785db0
Update Lib/test/test_tempfile.py
ShaharNaveh Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,7 @@ jobs:
extra_test_args: [] # TODO: Enable '-u all'
env_polluting_tests:
- test_set
- test_tempfile
skips: []
timeout: 50
fail-fast: false
Expand Down
3 changes: 2 additions & 1 deletion Lib/test/test_tempfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1746,7 +1746,8 @@ def test_cleanup_with_symlink_to_a_directory(self):
"were deleted")
d2.cleanup()

@unittest.skip("TODO: RUSTPYTHON; No such file or directory \"...\"")
@unittest.expectedFailureIf(sys.platform in ("android", "linux"), "TODO: RUSTPYTHON; FileNotFoundError: [Errno 2] No such file or directory: '<LONG_PATH>'")
Comment thread
ShaharNaveh marked this conversation as resolved.
@unittest.skipIf(sys.platform == 'win32' and "RUSTPYTHON_SKIP_ENV_POLLUTERS" in os.environ, "TODO: RUSTPYTHON")
@os_helper.skip_unless_symlink
def test_cleanup_with_symlink_modes(self):
# cleanup() should not follow symlinks when fixing mode bits (#91133)
Expand Down
Loading