Skip to content

Convert claude skills to more generic agent skills#8064

Open
bschoenmaeckers wants to merge 3 commits into
RustPython:mainfrom
bschoenmaeckers:convert-skills
Open

Convert claude skills to more generic agent skills#8064
bschoenmaeckers wants to merge 3 commits into
RustPython:mainfrom
bschoenmaeckers:convert-skills

Conversation

@bschoenmaeckers

@bschoenmaeckers bschoenmaeckers commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Documentation

    • Added new skill-style guides for running tests, investigating test failures, and upgrading stdlib modules.
    • Removed older command-style documentation that previously covered those same workflows.
  • Chores

    • Consolidated and migrated command-style docs into a skills-based structure for clearer, centralized guidance.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: a2253b0f-0c54-4edb-b041-b029403a0ce3

📥 Commits

Reviewing files that changed from the base of the PR and between c355b2e and 224060a.

📒 Files selected for processing (3)
  • .agents/skills/investigate-test-failure/SKILL.md
  • .agents/skills/upgrade-pylib-next/SKILL.md
  • .agents/skills/upgrade-pylib/SKILL.md
✅ Files skipped from review due to trivial changes (3)
  • .agents/skills/upgrade-pylib/SKILL.md
  • .agents/skills/upgrade-pylib-next/SKILL.md
  • .agents/skills/investigate-test-failure/SKILL.md

📝 Walkthrough

Walkthrough

This PR migrates four agent command workflows from .claude/commands/ markdown into standardized .agents/skills/ SKILL.md files, adding skills for apple-container, investigate-test-failure, upgrade-pylib-next, and upgrade-pylib with metadata and stepwise procedures.

Changes

Agent Skills Documentation

Layer / File(s) Summary
apple-container skill
.agents/skills/apple-container/SKILL.md
New skill with metadata and workflow for running RustPython tests in Apple container Linux environment on macOS, including container startup, test execution via container exec and cargo run --release -- -m test <args>, and operational notes (rebuild/cleanup).
investigate-test-failure skill
.agents/skills/investigate-test-failure/SKILL.md
New skill defining a procedure to analyze failing tests, verify behavior against CPython, decide between fixing vs. reporting incompatibility, and create structured issues using a template for complex cases.
upgrade-pylib-next skill
.agents/skills/upgrade-pylib-next/SKILL.md
New skill for selecting the next stdlib module to upgrade by querying scripts/update_lib todo, filtering modules with open PRs, prioritizing modules with no or resolved dependencies, and triggering the upgrade-pylib workflow.
upgrade-pylib skill
.agents/skills/upgrade-pylib/SKILL.md
New skill describing the multi-step upgrade workflow using scripts/update_lib (quick/migrate/auto-mark modes), restoring RustPython-specific diffs, investigating test failures, marking remaining failures, and handling panics/hangs or subclass-specific cases.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

skip:ci

Suggested reviewers

  • youknowone
  • ShaharNaveh
  • fanninpm

Poem

🐰 I hopped through docs with nimble feet,
From .claude to .agents, tidy and neat.
Containers, tests, and pylib plans,
Four new skills placed by careful hands.
Cheers — this rabbit's done a tidy feat!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: moving skill definitions from .claude/commands/ to .agents/skills/ for a more generic agent framework.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.agents/skills/apple-container/SKILL.md:
- Line 40: The documented command uses `sh -c` with interpolated `<test-args>`,
which permits shell metacharacters and command injection; change the example to
a shell-safe invocation that does not interpolate user args into the command
string (for example, run `sh -c` with positional parameter forwarding and pass
the test args after the `--` so they become "$@" inside the shell, or avoid `sh
-c` entirely and invoke `cargo run --release -- -m test` directly with the test
args as positional parameters); update the line containing `container exec
rustpython-test sh -c "cargo run --release -- -m test <test-args>"` to use safe
positional forwarding instead.
- Around line 32-34: The container run example in SKILL.md uses a hardcoded host
path in the mount (source=/Users/al03219714/Projects/RustPython3) which breaks
portability; update the documented command line for the "container run -d --name
rustpython-test -m 8G -c 4 \ ... -w /workspace rustpython-dev sleep infinity"
example to use a dynamic repo-root or current-directory variable (e.g., $(pwd)
or the output of git rev-parse --show-toplevel or an environment variable like
REPO_ROOT) for the --mount source instead of the hardcoded absolute path so the
command works on other machines.

In @.agents/skills/investigate-test-failure/SKILL.md:
- Line 4: The allowed-tools list in SKILL.md does not permit the gh CLI but the
skill uses a concrete gh issue create command; update the allowed-tools metadata
by adding an entry that permits this command (e.g., add Bash(gh issue create:*)
to the allowed-tools list) or remove/replace the gh issue create invocation in
the skill steps (search for the literal "gh issue create" and the allowed-tools
line in SKILL.md to apply the change).

In @.agents/skills/upgrade-pylib-next/SKILL.md:
- Line 4: The allowed-tools metadata entry (the allowed-tools list) is missing
permission for the workflow's cargo run usage; update the allowed-tools list to
include the cargo run tool (e.g., add an entry like Cargo(cargo run:*) or the
appropriate tool identifier for cargo run) so the workflow step that invokes
`cargo run` (the line referencing cargo run) is permitted; ensure you add this
alongside the existing Skill(upgrade-pylib) and Bash(...) entries to cover lines
13-17 where cargo run is used.

In @.agents/skills/upgrade-pylib/SKILL.md:
- Line 4: The allowed-tools metadata entry (the allowed-tools key in
.agents/skills/upgrade-pylib/SKILL.md) is missing commands used by the
documented steps; update that allowed-tools list to include the missing commands
(at minimum add git diff and cargo run) so the documented workflow commands are
permitted, and ensure any other commands referenced in the SKILL.md steps (e.g.,
scripts/update_lib invocations already present) are reflected in the same
allowed-tools list to keep metadata and documentation consistent.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 9b50ed75-3f4d-4eb0-a3a3-d6a59b5c7cbf

📥 Commits

Reviewing files that changed from the base of the PR and between fb422da and 81466d8.

📒 Files selected for processing (8)
  • .agents/skills/apple-container/SKILL.md
  • .agents/skills/investigate-test-failure/SKILL.md
  • .agents/skills/upgrade-pylib-next/SKILL.md
  • .agents/skills/upgrade-pylib/SKILL.md
  • .claude/commands/apple-container.md
  • .claude/commands/investigate-test-failure.md
  • .claude/commands/upgrade-pylib-next.md
  • .claude/commands/upgrade-pylib.md
💤 Files with no reviewable changes (4)
  • .claude/commands/upgrade-pylib-next.md
  • .claude/commands/investigate-test-failure.md
  • .claude/commands/apple-container.md
  • .claude/commands/upgrade-pylib.md

Comment thread .agents/skills/apple-container/SKILL.md
Comment thread .agents/skills/apple-container/SKILL.md Outdated
Comment thread .agents/skills/investigate-test-failure/SKILL.md Outdated
Comment thread .agents/skills/upgrade-pylib-next/SKILL.md Outdated
Comment thread .agents/skills/upgrade-pylib/SKILL.md Outdated
bschoenmaeckers and others added 2 commits June 9, 2026 11:31
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

@ShaharNaveh ShaharNaveh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tysm for doing this!

@ShaharNaveh ShaharNaveh added the skip:ci Skip running the ci label Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip:ci Skip running the ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants