Add iter support to c-api#8035
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds an iter submodule re-export and C-ABI FFI bindings for iterator operations (check, get-iter, next-item, next, send) plus a new PyObject_Size function that returns an object's length via obj.length(vm). ChangesIterator and Object Measurement C API Extension
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bschoenmaeckers
force-pushed
the
c-api-iter
branch
from
84b2e08 to
39772a7
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/capi/src/abstract_/iter.rs`:
- Around line 65-68: In PyIter_Send, change the current hard downcast to
PyGenerator so it matches CPython: first check if arg_obj.is_none(); if so,
attempt to downcast iter_obj to PyGenerator and call as_coro().send(...) when it
is a generator, but if it's not a generator call PyIter::new(iter_obj).next(vm)
to advance the iterator; if arg_obj is not None and iter_obj is not a
PyGenerator, raise a TypeError. Use the existing methods
try_downcast_ref::<PyGenerator>, PyGenerator::as_coro().send, and
PyIter::new(iter_obj).next(vm) to implement the fallback.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: 6cd14683-2403-4826-83dd-15a54a1a8120
📒 Files selected for processing (2)
crates/capi/src/abstract_.rscrates/capi/src/abstract_/iter.rs
bschoenmaeckers
force-pushed
the
c-api-iter
branch
from
39772a7 to
21fffc5
Compare
youknowone
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit