Skip to content

CI: Don't skip windows tests#8004

Merged
youknowone merged 2 commits into
RustPython:mainfrom
ShaharNaveh:ci-windows-dont-skip
Jun 2, 2026
Merged

CI: Don't skip windows tests#8004
youknowone merged 2 commits into
RustPython:mainfrom
ShaharNaveh:ci-windows-dont-skip

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Jun 1, 2026 •
edited by youknowone
Loading

Copy link
Copy Markdown
Contributor

Summary

Summary by CodeRabbit

  • Chores
    • Enhanced CI/CD testing configuration to enable additional Windows compatibility verification for CPython.

@coderabbitai

coderabbitai Bot commented Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The Windows CPython test matrix configuration in the CI workflow is updated to remove previously skipped tests by clearing the skips list to an empty array. This enables all CPython tests to run on Windows without exclusions.

Changes

Windows CPython Test Skip Configuration

Layer / File(s) Summary
Windows CPython test skip removal
.github/workflows/ci.yaml		 The Windows snippets_cpython matrix entry replaces its populated skips list with an empty list, allowing all CPython tests to run without exclusions for that configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • youknowone
  • fanninpm
  • bschoenmaeckers

Poem

🐰 The Windows tests now run free,
No skips to hold them back, you see!
CPython tests, once left behind,
Now execute with unburdened mind.
Empty the list, let them all run—
CI's work on Windows, freshly begun!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'CI: Don't skip windows tests' directly matches the changeset, which removes skips from the Windows matrix entry in the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] lib: cpython/Lib/venv
[x] test: cpython/Lib/test/test_venv.py (TODO: 17)

dependencies:

  • venv

dependent tests: (1 tests)

  • venv: test_venv

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

@youknowone youknowone enabled auto-merge (squash) June 1, 2026 15:36
@ShaharNaveh

ShaharNaveh commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

@youknowone because it's waiting for the cached CI entry to complete it's not gonna be auto-merged:/

@youknowone youknowone disabled auto-merge June 2, 2026 06:40
@youknowone youknowone merged commit 0c9ed36 into RustPython:main Jun 2, 2026
27 checks passed
@youknowone

youknowone commented Jun 2, 2026

Copy link
Copy Markdown
Member

Thanks, I have to remove the old one and add new one in settings whenever the CI task name is changed.

@fanninpm fanninpm mentioned this pull request Jun 2, 2026
Merged
2 tasks
JamesClarke7283 added a commit to JamesClarke7283/RustPython that referenced this pull request Jun 3, 2026
@JamesClarke7283 @claude
Merge branch 'main' into fix-7941-thread-stack-overflow
41b4f73 
Brings the branch up to date with main so CI job names match the
required status checks (the windows snippets/cpython job was renamed
by RustPython#8004 when its matrix skips were cleared). Also picks up RustPython#8018's
_thread.rs stack-margin updates, which are orthogonal to the
apply_thread_stack_size fix in this PR.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle windows test proper way

2 participants

@ShaharNaveh @youknowone