Skip to content

Align all remaining error messages with CPython #7993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JamesClarke7283 wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Align all remaining error messages with CPython #7993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
be45903
Align more parser/SyntaxError messages with CPython 3.14.5
JamesClarke7283 May 29, 2026
e6b1f7b
Fix wasm32_without_js link error: declare host fns as `env` imports
JamesClarke7283 May 29, 2026
8ea3d32
Lib/test: drop now-passing expectedFailure markers
JamesClarke7283 May 29, 2026
2e00518
codegen: extract validate_type_params_no_debug helper
JamesClarke7283 May 29, 2026
d53af6f
Update crates/compiler/src/lib.rs
JamesClarke7283 May 30, 2026
deb8e72
codegen: align star/double-comma display errors with CPython
JamesClarke7283 May 31, 2026
669fc00
Fix star/dict-value SyntaxError false-positives vs CPython 3.14.5
JamesClarke7283 Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Lib/test/test_dictcomps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ def test_local_visibility(self):
self.assertEqual(actual, expected)
self.assertEqual(v, "Local variable")

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_illegal_assignment(self):
with self.assertRaisesRegex(SyntaxError, "cannot assign"):
compile("{x: y for y, x in ((1, 2), (3, 4))} = 5", "<test>",
Expand Down
1 change: 0 additions & 1 deletion Lib/test/test_fstring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1292,7 +1292,6 @@ def test_nested_fstrings(self):
self.assertEqual(f'{f"{0}"*3}', '000')
self.assertEqual(f'{f"{y}"*3}', '555')

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_invalid_string_prefixes(self):
single_quote_cases = ["fu''",
"uf''",
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_genexps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@
...
SyntaxError: cannot assign to generator expression

>>> (y for y in (1,2)) += 10 # TODO: RUSTPYTHON # doctest: +EXPECTED_FAILURE
>>> (y for y in (1,2)) += 10
Traceback (most recent call last):
...
SyntaxError: 'generator expression' is an illegal expression for augmented assignment
Expand Down
6 changes: 0 additions & 6 deletions Lib/test/test_named_expressions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,35 +4,30 @@

class NamedExpressionInvalidTest(unittest.TestCase):

@unittest.expectedFailure # TODO: RUSTPYTHON; wrong error message
def test_named_expression_invalid_01(self):
code = """x := 0"""

with self.assertRaisesRegex(SyntaxError, "invalid syntax"):
exec(code, {}, {})

@unittest.expectedFailure # TODO: RUSTPYTHON; wrong error message
def test_named_expression_invalid_02(self):
code = """x = y := 0"""

with self.assertRaisesRegex(SyntaxError, "invalid syntax"):
exec(code, {}, {})

@unittest.expectedFailure # TODO: RUSTPYTHON; wrong error message
def test_named_expression_invalid_03(self):
code = """y := f(x)"""

with self.assertRaisesRegex(SyntaxError, "invalid syntax"):
exec(code, {}, {})

@unittest.expectedFailure # TODO: RUSTPYTHON; wrong error message
def test_named_expression_invalid_04(self):
code = """y0 = y1 := f(x)"""

with self.assertRaisesRegex(SyntaxError, "invalid syntax"):
exec(code, {}, {})

@unittest.expectedFailure # TODO: RUSTPYTHON; wrong error message
def test_named_expression_invalid_06(self):
code = """((a, b) := (1, 2))"""

Expand Down Expand Up @@ -103,7 +98,6 @@ def test_named_expression_invalid_16(self):
with self.assertRaisesRegex(SyntaxError, "invalid syntax"):
exec(code, {}, {})

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_named_expression_invalid_17(self):
code = "[i := 0, j := 1 for i, j in [(1, 2), (3, 4)]]"

Expand Down
1 change: 0 additions & 1 deletion Lib/test/test_patma.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2955,7 +2955,6 @@ def test_invalid_syntax_2(self):
pass
""")

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_invalid_syntax_3(self):
self.assert_syntax_error("""
match ...:
Expand Down
Loading
Loading