Skip to content

Update test_unicodedata.py to 3.14.4#7750

Merged
youknowone merged 6 commits into
RustPython:mainfrom
ShaharNaveh:update-test-unicodedata
May 1, 2026
Merged

Update test_unicodedata.py to 3.14.4#7750
youknowone merged 6 commits into
RustPython:mainfrom
ShaharNaveh:update-test-unicodedata

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented May 1, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Release Notes

  • Chores
    • Internal updates to test patch management tooling to improve handling of unittest decorator configurations.

Note: This release contains internal infrastructure improvements with no direct impact on user-facing functionality.

@coderabbitai

coderabbitai Bot commented May 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: d71ad093-5fe3-4c52-8d29-d2ec122d66ed

📥 Commits

Reviewing files that changed from the base of the PR and between e79df4a and 148b1b4.

⛔ Files ignored due to path filters (3)
  • Lib/test/NormalizationTest-3.2.0.txt is excluded by !Lib/**
  • Lib/test/test_unicodedata.py is excluded by !Lib/**
  • Lib/unittest/__init__.py is excluded by !Lib/**
📒 Files selected for processing (1)
  • scripts/update_lib/patch_spec.py
📝 Walkthrough

Walkthrough

The UtMethod enum in the patch specification module is extended with a new ExpectedSuccess value. The has_args() method is updated to treat both ExpectedFailure and ExpectedSuccess as argumentless decorator methods, modifying how unittest decorators are constructed and reason extraction is handled.

Changes

Cohort / File(s) Summary
Enum Extension and Method Logic Update
scripts/update_lib/patch_spec.py		 Added ExpectedSuccess enum value to UtMethod and updated has_args() method to treat both ExpectedFailure and ExpectedSuccess as argumentless, changing decorator construction and reason extraction behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A decorator grows with grace so new,
ExpectedSuccess joins the argumentless crew,
With ExpectedFailure in harmonious pair,
The unittest logic floats through the air! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions updating 'test_unicodedata.py to 3.14.4', but the actual changes affect 'scripts/update_lib/patch_spec.py' with enum and method updates unrelated to unicodedata testing. Update the title to reflect the actual changes, such as 'Add ExpectedSuccess to UtMethod enum and update has_args() logic' or similar to accurately describe the patch_spec.py modifications.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented May 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

(module 'unicodedata unittest' not found)

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

ShaharNaveh
ShaharNaveh commented May 1, 2026
View reviewed changes
Comment thread Lib/unittest/__init__.py

# XXX: RUSTPYTHON
# For a rare case when the parent class test fails but the child pass.
def expectedSuccess(test_item):

@ShaharNaveh ShaharNaveh May 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@youknowone I can move it to a separate PR if desired

@youknowone youknowone May 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's ok. we need this feature for this PR

@ShaharNaveh ShaharNaveh requested review from fanninpm and youknowone May 1, 2026 10:08
@youknowone youknowone merged commit bb77ac6 into RustPython:main May 1, 2026
21 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request May 9, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

@fanninpm fanninpm Awaiting requested review from fanninpm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone