Skip to content

Make updating actions cache synchronous #7712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 1 commit into from
May 1, 2026
Merged

Make updating actions cache synchronous #7712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/update-caches.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
branches:
- main

concurrency:
group: ${{ github.workflow }}
cancel-in-progress: false

@ShaharNaveh ShaharNaveh Apr 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on the fence regarding setting this to true.

What do you think @fanninpm?

@fanninpm fanninpm Apr 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting this to true should be safe as long as all the caches are uploaded at the very end of the workflow.

@ShaharNaveh ShaharNaveh Apr 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting this to true would cause running jobs to be canceled if there's a new one in queue. So in theory, the caches would never update until there will be no pushes to main for long period of time (depends on how many PRs were merged at that time window).

Setting this to false would never cancel already running jobs, but will skip any in-queue job that wasn't started yet.


env:
CARGO_INCREMENTAL: 0
CARGO_TERM_COLOR: always
Expand Down
Loading