Skip to content

Update test_cmath.py from 3.14.4#7623

Merged
youknowone merged 1 commit into
RustPython:mainfrom
changjoon-park:update-test-cmath
Apr 19, 2026
Merged

Update test_cmath.py from 3.14.4#7623
youknowone merged 1 commit into
RustPython:mainfrom
changjoon-park:update-test-cmath

Conversation

@changjoon-park

@changjoon-park changjoon-park commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Syncs Lib/test/test_cmath.py with CPython 3.14.4.

Adds the SunOS skip decorator on test_phase introduced in CPython (gh-138573).

Follows the same pattern as #7607, #7609, #7614, #7618.

@coderabbitai

coderabbitai Bot commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Lib/test/test_cmath.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 96287694-39f9-408a-b557-00d655c6a470

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] test: cpython/Lib/test/test_cmath.py

dependencies:

dependent tests: (1 tests)

  • cmath: test_cmath

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

ShaharNaveh
ShaharNaveh approved these changes Apr 18, 2026
View reviewed changes

@ShaharNaveh ShaharNaveh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tysm!
welcome to the project:)

@changjoon-park

changjoon-park commented Apr 18, 2026

Copy link
Copy Markdown
Contributor Author

tysm!
welcome to the project:)

Thank you for the review 😊

@youknowone youknowone merged commit 9a0410d into RustPython:main Apr 19, 2026
21 checks passed
@changjoon-park changjoon-park deleted the update-test-cmath branch April 19, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaharNaveh ShaharNaveh ShaharNaveh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@changjoon-park @ShaharNaveh @youknowone