Skip to content

Make singleton builtin types immutable #7423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 1 commit into from
Mar 14, 2026
Merged

Make singleton builtin types immutable #7423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Lib/test/test_builtin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2434,7 +2434,6 @@ def test_bool_notimplemented(self):
with self.assertRaisesRegex(TypeError, msg):
not NotImplemented

@unittest.expectedFailure # TODO: RUSTPYTHON; AssertionError: TypeError not raised
def test_singleton_attribute_access(self):
for singleton in (NotImplemented, Ellipsis):
with self.subTest(singleton):
Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/builtins/singletons.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ impl Constructor for PyNotImplemented {
}
}

#[pyclass(with(Constructor, AsNumber, Representable))]
#[pyclass(with(Constructor, AsNumber, Representable), flags(IMMUTABLETYPE))]
impl PyNotImplemented {
#[pymethod]
fn __reduce__(&self, vm: &VirtualMachine) -> PyStrRef {
Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/builtins/slice.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ impl Constructor for PyEllipsis {
}
}

#[pyclass(with(Constructor, Representable))]
#[pyclass(with(Constructor, Representable), flags(IMMUTABLETYPE))]
impl PyEllipsis {
#[pymethod]
fn __reduce__(&self, vm: &VirtualMachine) -> PyStrRef {
Expand Down
Loading