Skip to content

Update subprocess.py to 3.14.3 #7244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Feb 28, 2026
Merged

Update subprocess.py to 3.14.3 #7244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4602edf
Update `subprocess.py` to 3.14.3
ShaharNaveh Feb 27, 2026
cc5a128
Merge remote-tracking branch 'upstream/main' into update-subprocess
ShaharNaveh Feb 27, 2026
03c642a
Merge remote-tracking branch 'upstream/main' into update-subprocess
ShaharNaveh Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2141,7 +2141,7 @@ def _communicate(self, input, endtime, orig_timeout):

while selector.get_map():
timeout = self._remaining_time(endtime)
if timeout is not None and timeout < 0:
if timeout is not None and timeout <= 0:
self._check_timeout(endtime, orig_timeout,
stdout, stderr,
skip_check_and_raise=True)
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1903,7 +1903,7 @@ def test_run_with_pathlike_path_and_arguments(self):
res = subprocess.run(args)
self.assertEqual(res.returncode, 57)

@unittest.skipIf(mswindows, 'TODO: RUSTPYTHON; empty env block fails nondeterministically')
@unittest.skipIf(mswindows, "TODO: RUSTPYTHON; empty env block fails nondeterministically")
@unittest.skipUnless(mswindows, "Maybe test trigger a leak on Ubuntu")
def test_run_with_an_empty_env(self):
# gh-105436: fix subprocess.run(..., env={}) broken on Windows
Expand Down
Loading