Skip to content

Avoid attribute protocol #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cthulahoops merged 2 commits into from
Mar 22, 2019
Merged

Avoid attribute protocol #709

cthulahoops merged 2 commits into from
Mar 22, 2019

Conversation

@cthulahoops
Copy link
Collaborator

@cthulahoops cthulahoops commented Mar 21, 2019

First batch of my big change (breaking it up a bit for review friendliness).

@cthulahoops
Copy link
Collaborator Author

cthulahoops commented Mar 21, 2019

All this use of AttributeProtocol is using the internal interface rather than the proper vm attribute path.

@codecov-io
Copy link

codecov-io commented Mar 21, 2019 •
edited
Loading

Codecov Report

Merging #709 into master will increase coverage by 2.85%.
The diff coverage is 53.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
+ Coverage   50.05%   52.91%   +2.85%     
==========================================
  Files          81       81              
  Lines       15196    15564     +368     
  Branches     3661     3853     +192     
==========================================
+ Hits         7607     8235     +628     
+ Misses       5769     5485     -284     
- Partials     1820     1844      +24
Impacted Files Coverage Δ
src/main.rs 14.01% <0%> (-10.32%) ⬇️
vm/src/stdlib/re.rs 27.1% <0%> (-18.09%) ⬇️
vm/src/stdlib/io.rs 30.19% <0%> (-0.65%) ⬇️
vm/src/vm.rs 70.29% <100%> (+18.27%) ⬆️
vm/src/sysmodule.rs 61.66% <100%> (-0.41%) ⬇️
vm/src/import.rs 51.78% <33.33%> (-11.48%) ⬇️
vm/src/obj/objstaticmethod.rs 46.87% <50%> (-7.3%) ⬇️
vm/src/obj/objclassmethod.rs 50% <55.17%> (-9.26%) ⬇️
vm/src/frame.rs 49.02% <75%> (-0.92%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0838e30...23ee751. Read the comment docs.

coolreader18
coolreader18 requested changes Mar 21, 2019
View reviewed changes
@cthulahoops cthulahoops force-pushed the avoid_attribute_protocol branch from 0bef545 to 23ee751 Compare March 22, 2019 10:54
@cthulahoops
Copy link
Collaborator Author

cthulahoops commented Mar 22, 2019

Review comments addressed. Merging.

@cthulahoops cthulahoops merged commit e7eff34 into master Mar 22, 2019
@cthulahoops cthulahoops deleted the avoid_attribute_protocol branch April 9, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coolreader18 coolreader18 Awaiting requested review from coolreader18

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cthulahoops @codecov-io @coolreader18