Fix the Display impl for PyRef #707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
approved these changes
Mar 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
========================================
- Coverage 52.9% 51.1% -1.8%
========================================
Files 81 81
Lines 14617 14988 +371
Branches 3441 3557 +116
========================================
- Hits 7733 7660 -73
- Misses 5072 5510 +438
- Partials 1812 1818 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously used the target's
Debugimpl which leads to surprising results.(Also, to avoid implementing
DisplayforPyTupleandPyList, I corrected the comparison methods on these to returnNotImplementedinstead of formatting and raising their own errors.)