Skip to content

[update_lib] fix hard_deps resolution and fix commit not to miss test data #7058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowone merged 2 commits into from
Feb 9, 2026
Merged

[update_lib] fix hard_deps resolution and fix commit not to miss test data #7058

youknowone merged 2 commits into from
Feb 9, 2026
+22 −14

Conversation

@youknowone
Copy link
Member

@youknowone youknowone commented Feb 9, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

Release Notes

  • Refactor
    • Updated dependency tracking to collect and propagate additional file paths during library updates.
    • Improved test dependency extraction with unified path resolution logic, reducing redundant processing.

@youknowone youknowone added the skip:ci Skip running the ci label Feb 9, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The PR modifies dependency tracking in scripts/update_lib/. The quick() function now returns a list of collected paths (data directories and hard dependencies) instead of None, enabling callers to extend their dependency lists. Meanwhile, deps.py refines import resolution logic to skip test_ modules during extraction and unifies non-test import path resolution.

Changes

Cohort / File(s) Summary
Quick function return value
scripts/update_lib/cmd_quick.py		 Changed quick() return type from None to list[pathlib.Path]. Introduced internal extra_paths accumulator to collect migrated dependencies and copied data directories. Updated docstring and propagated return value to callers, which now extend hard_deps_for_commit with collected paths.
Import resolution logic
scripts/update_lib/deps.py		 Modified test dependency extraction to skip imports from test\_ modules entirely, delegating them to separate update_lib entries. Unified non-test import path resolution using a single lookup with fallback, removing previous branching logic between test and support module handling.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • moreal
  • ShaharNaveh

Poem

🐰 Dependencies now hop back home,
Paths collected, no more to roam,
Quick returns what it finds,
Tests skip their own kinds,
A cleaner update_lib zone! 🌟

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone youknowone marked this pull request as ready for review February 9, 2026 05:41
@youknowone youknowone merged commit c974b77 into RustPython:main Feb 9, 2026
8 of 9 checks passed
@youknowone youknowone deleted the update_lib branch February 9, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip:ci Skip running the ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@youknowone