Add __class__ cell to method scopes. #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windelbouwman
approved these changes
Mar 20, 2019
Contributor
windelbouwman
left a comment
windelbouwman
left a comment
There was a problem hiding this comment.
I do not understand the cell idea, but the change looks okay.
Collaborator
Author
|
A cellvar is the just cpython name/implementation for variables that captured from non-local, non-global scopes/the optimisation that makes them fast. I may be vague on the details too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic implementation that I think should be good enough for
__super__to work.This should be passed through to the metaclass to allow some more advanced trickery, but I think this is good enough. There's a more optimal implementation than a whole dictionary just for this, which we can sort when we come to optimise local variables.