Skip to content

Change the WASM example to use rustpython from npm #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
windelbouwman merged 1 commit into from
Mar 21, 2019
Merged

Change the WASM example to use rustpython from npm #700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions wasm/example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
{
"name": "rustpython-wasm-example",
"version": "1.0.0",
"//1": "`dependencies.rustpython_wasm` would be the version of the npm",
"//2": "library in a real app",
"dependencies": {
"rustpython_wasm": "file:../lib/pkg/"
"rustpython_wasm": "0.1.0-pre-alpha.1"
Copy link
Contributor

@windelbouwman windelbouwman Mar 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you do this? Then we cannot test the current version, but always go through a deployment phase via npm?

Copy link
Member Author

@coolreader18 coolreader18 Mar 20, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for the example, not the demo. If someone just wanted to copy/paste the example and use it as their own project, currently, they couldn't do so, as it has a file: dependency; they'd have to change it to the version from npm.

},
"devDependencies": {
"raw-loader": "1.0.0",
"webpack": "4.28.2",
"webpack-cli": "^3.1.2"
},
"scripts": {
"build": "webpack"
"build": "webpack",
"dist": "webpack --mode production"
},
"license": "MIT"
}