Skip to content

Update test_tstring from v3.14.2 - #6946

Merged
youknowone merged 3 commits into
RustPython:mainfrom
fanninpm:3.14-test_tstring
Feb 1, 2026
Merged

Update test_tstring from v3.14.2#6946
youknowone merged 3 commits into
RustPython:mainfrom
fanninpm:3.14-test_tstring

Conversation

@fanninpm

@fanninpm fanninpm commented Feb 1, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Enhanced automated test coverage during continuous integration runs across multiple platforms to improve code quality assurance.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Feb 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request adds test_tstring to the PLATFORM_INDEPENDENT_TESTS list in the CI workflow configuration, expanding the set of tests executed across Linux, macOS, and Windows platforms during matrix test runs.

Changes

Cohort / File(s) Summary
CI Configuration
.github/workflows/ci.yaml		 Added test_tstring to the PLATFORM_INDEPENDENT_TESTS environment variable, expanding platform-independent test coverage in the matrix workflow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • RustPython#6928: Also modifies .github/workflows/ci.yaml to add a specific test to PLATFORM_INDEPENDENT_TESTS, following a similar pattern of expanding platform-independent test coverage.

Suggested reviewers

  • youknowone

Poem

🐰 A string test hops along the CI track,
test_tstring now has developer's back,
On Windows, Mac, and Linux it will run,
Cross-platform testing—three in one! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title references 'Update test_tstring from v3.14.2' but the actual change only adds test_tstring to PLATFORM_INDEPENDENT_TESTS in CI config, not updating from a specific version. Clarify the title to reflect the actual change: consider 'Add test_tstring to CI platform-independent tests' or similar to accurately describe the modification.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Feb 1, 2026

Copy link
Copy Markdown
Contributor

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] test: cpython/Lib/test/test_tstring.py (TODO: 5)

dependencies:

dependent tests: (no tests depend on tstring)

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

@fanninpm fanninpm mentioned this pull request Feb 1, 2026
Open
@fanninpm
fanninpm marked this pull request as ready for review February 1, 2026 21:09
@youknowone
youknowone merged commit 89dbd42 into RustPython:main Feb 1, 2026
14 checks passed
@fanninpm
fanninpm deleted the 3.14-test_tstring branch February 1, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fanninpm @youknowone