Skip to content

Update test_unpack_ex from v3.14.2#6945

Merged
youknowone merged 3 commits intoRustPython:mainfrom
fanninpm:3.14-test_unpack_ex
Feb 1, 2026
Merged

Update test_unpack_ex from v3.14.2#6945
youknowone merged 3 commits intoRustPython:mainfrom
fanninpm:3.14-test_unpack_ex

Conversation

@fanninpm
Copy link
Contributor

@fanninpm fanninpm commented Feb 1, 2026 •
edited by coderabbitai bot
Loading

I realized that the previous version of CustomOutputChecker did not correctly handle the presence of other option flags, so I revised it and shaved a line.

Summary by CodeRabbit

  • Tests
    • Added a new test to the platform-independent test suite, which runs across Linux, macOS, and Windows environments.

✏️ Tip: You can customize this high-level summary in your review settings.

CPython Developers and others added 3 commits February 1, 2026 14:21
@fanninpm
Update test_unpack_ex from v3.14.2-288-g06f9c8ca1c
6f490d2
@fanninpm
Mark failing examples
784e203 
This caused me to revise the custom output checker so it can handle
other option flags.
@fanninpm
Make test_unpack_ex platform-independent
b805008
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 1, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

Adds test_unpack_ex to the PLATFORM_INDEPENDENT_TESTS list in the CI workflow configuration, expanding the test suite executed across Linux, macOS, and Windows platforms in the continuous integration pipeline.

Changes

Cohort / File(s) Summary
CI Configuration
.github/workflows/ci.yaml		 Added test_unpack_ex to the PLATFORM_INDEPENDENT_TESTS environment variable to include the test in platform-independent test suite execution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • youknowone
  • ShaharNaveh

Poem

🐰 A test joins the fold, hopping through the CI,
Unpack\_ex now runs where all platforms comply,
From Linux to Windows, it hops without care,
One line of change keeps the tests fair! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title 'Update test_unpack_ex from v3.14.2' is misleading. The actual change shown in raw_summary is adding test_unpack_ex to PLATFORM_INDEPENDENT_TESTS in CI workflow, not updating it from a version. Revise the title to accurately reflect the main change, such as 'Add test_unpack_ex to platform-independent test suite' or 'Enable test_unpack_ex as platform-independent test'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[ ] test: cpython/Lib/test/test_unpack.py
[ ] test: cpython/Lib/test/test_unpack_ex.py (TODO: 32)

dependencies:

dependent tests: (no tests depend on unpack)

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

@fanninpm fanninpm mentioned this pull request Feb 1, 2026
Open
@fanninpm fanninpm marked this pull request as ready for review February 1, 2026 19:53
@youknowone youknowone merged commit d46a3b4 into RustPython:main Feb 1, 2026
24 of 25 checks passed
@fanninpm fanninpm deleted the 3.14-test_unpack_ex branch February 1, 2026 23:14
@fanninpm fanninpm mentioned this pull request Feb 4, 2026
Merged
@coderabbitai coderabbitai bot mentioned this pull request Feb 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fanninpm @youknowone