Skip to content

fix: Include hard_deps in git commit - #6940

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowone:fix-commit
Feb 1, 2026
Merged

fix: Include hard_deps in git commit#6940
youknowone merged 1 commit into
RustPython:mainfrom
youknowone:fix-commit

Conversation

@youknowone

Copy link
Copy Markdown
Member

Bug: update_lib quick ast was not committing _ast_unparse.py because git_commit() only added lib_path and test_paths, but not hard_deps.

Fixed by:

  • Add hard_deps parameter to git_commit()
  • Collect hard_deps from DEPENDENCIES in main()
  • Add hard_deps to paths_to_add in git_commit()

Bug: update_lib quick ast was not committing _ast_unparse.py
because git_commit() only added lib_path and test_paths,
but not hard_deps.

Fixed by:
- Add hard_deps parameter to git_commit()
- Collect hard_deps from DEPENDENCIES in main()
- Add hard_deps to paths_to_add in git_commit()
@coderabbitai

coderabbitai Bot commented Feb 1, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@youknowone has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 23 minutes and 13 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone
youknowone marked this pull request as ready for review February 1, 2026 15:27
@youknowone
youknowone merged commit 68ebb61 into RustPython:main Feb 1, 2026
12 of 13 checks passed
@youknowone
youknowone deleted the fix-commit branch February 1, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant