Skip to content

Update enum from v3.14.2#6932

Merged
youknowone merged 2 commits into
RustPython:mainfrom
youknowone:enum
Feb 1, 2026
Merged

Update enum from v3.14.2#6932
youknowone merged 2 commits into
RustPython:mainfrom
youknowone:enum

Conversation

@youknowone

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Feb 1, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • Lib/enum.py is excluded by !Lib/**
  • Lib/test/test_enum.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread Lib/test/test_enum.py
two = b'2', 'ascii', 9

@unittest.expectedFailure # TODO: RUSTPYTHON; fails on encoding testing : TypeError: Expected type 'str' but 'builtin_function_or_method' found
@unittest.expectedFailure # TODO: RUSTPYTHON; fails on encoding testing : TypeError: Expected type 'str' but 'builtin_function_or_method' found

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the double space before the comment intentional?

# used to be
@unittest.expectedFailure # TODO: RUSTPYTHON; ...
# now it's
@unittest.expectedFailure  # TODO: RUSTPYTHON; ...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the tradition from PEP-8#inline-comments

... Inline comments should be separated by at least two spaces from the statement. They should start with a # and a single space.

@youknowone youknowone marked this pull request as ready for review February 1, 2026 08:46
Comment thread Lib/test/test_enum.py Outdated
@youknowone youknowone merged commit 0b9c90f into RustPython:main Feb 1, 2026
3 checks passed
@youknowone youknowone deleted the enum branch February 1, 2026 10:14
@github-actions

github-actions Bot commented Feb 1, 2026

Copy link
Copy Markdown
Contributor

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] lib: cpython/Lib/enum.py
[x] test: cpython/Lib/test/test_enum.py (TODO: 11)

dependencies:

  • enum

dependent tests: (10 tests)

  • enum: test_argparse test_ast test_enum test_httplib test_json test_patma test_signal test_ssl test_time test_uuid

[x] test: cpython/Lib/test/test_coroutines.py (TODO: 25)

dependencies:

dependent tests: (no tests depend on coroutines)

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants