Update sqlite3 and the tests to CPython 3.14.2#6787
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (17)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ever0de
force-pushed
the
update-test-sqlite3-cpython-3.14
branch
from
f185847 to
5d18754
Compare
ever0de
changed the title
ever0de
changed the title
|
Python has 3.14.2 tag now |
ever0de
force-pushed
the
update-test-sqlite3-cpython-3.14
branch
from
5d18754 to
a5ecafe
Compare
ever0de
changed the title
|
how about Lib/sqlite3? isn't it changed? |
Oh, I'm running sqlite tests to identify what needs to be updated. I'm working through Lib/sqlite3 and Lib/test/test_sqlite3/** locally. It looks like the tests are deadlocking, so I'm investigating it. |
ever0de
force-pushed
the
update-test-sqlite3-cpython-3.14
branch
2 times, most recently
from
fea9132 to
afc44cb
Compare
Skip tests that fail due to unimplemented features or behavior differences: - _iterdump not implemented (test_dump.py) - Unraisable exception handling not implemented (test_hooks.py, test_userfunctions.py) - Keyword-only arguments not supported for various methods - Autocommit behavior differences (test_transactions.py) - TransactionTests skipped due to timeout parameter type issue - Various error message differences (test_dbapi.py) - SQLITE_DBCONFIG constants not implemented - Row and Connection signature inspection issues All tests now pass with 95 skipped out of 493 total tests.
ever0de
force-pushed
the
update-test-sqlite3-cpython-3.14
branch
from
afc44cb to
494326a
Compare
youknowone
changed the title
youknowone
left a comment
youknowone
left a comment
There was a problem hiding this comment.
I'd like to check if newly added @unittest.skip was not avoidable.
Just in case, we prefer @unittest.expectedFailure over @unittest.skip
| [self.assertEqual(expected_sqls[i], actual_sqls[i]) | ||
| for i in range(len(expected_sqls))] | ||
|
|
||
| @unittest.skip("TODO: RUSTPYTHON iterdump filter parameter not implemented") |
There was a problem hiding this comment.
Is the test panic or hang? If it just fail, we prefer to mark it as expectedFailure
There was a problem hiding this comment.
I changed the few tests that were hanging to @unittest.skip, and marked the rest as expectedFailure. Thank you.
- Convert @unittest.skip decorators to @unittest.expectedFailure for tests that fail without panic/hang - Keep @unittest.skip only for TransactionTests class (setUp fails with timeout=0 int type)
2 participants
fixed #6785