Skip to content

Fix some parts of cron-ci workflow #6724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 7 commits into from
Jan 14, 2026
+12 −5
Merged

Fix some parts of cron-ci workflow #6724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7b501ed
Use shared PYTHON_VERSION in cron-ci benchmark job
moreal Jan 13, 2026
a22ae08
Correct extra-tests/jsontests.py script
moreal Jan 13, 2026
eb415bc
Use ssl-rustls feature instead of ssl in cron-ci workflow
moreal Jan 13, 2026
c6eb610
Replace inspect.getargspec with inspect.getfullargspec in custom_text…
moreal Jan 13, 2026
be78d70
Exclude rustpython-venvlauncher in cron-ci workflow
moreal Jan 13, 2026
801113c
Apply suggestion from @fanninpm
youknowone Jan 14, 2026
2b6e112
Trigger cron-ci workflow in pull_request
moreal Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/workflows/cron-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,14 @@ on:
push:
paths:
- .github/workflows/cron-ci.yaml
pull_request:
paths:
- .github/workflows/cron-ci.yaml

name: Periodic checks/tasks

env:
CARGO_ARGS: --no-default-features --features stdlib,importlib,encodings,ssl,jit
CARGO_ARGS: --no-default-features --features stdlib,importlib,encodings,ssl-rustls,jit
PYTHON_VERSION: "3.13.1"

jobs:
Expand All @@ -29,7 +32,7 @@ jobs:
python-version: ${{ env.PYTHON_VERSION }}
- run: sudo apt-get update && sudo apt-get -y install lcov
- name: Run cargo-llvm-cov with Rust tests.
run: cargo llvm-cov --no-report --workspace --exclude rustpython_wasm --verbose --no-default-features --features stdlib,importlib,encodings,ssl,jit
run: cargo llvm-cov --no-report --workspace --exclude rustpython_wasm --exclude rustpython-compiler-source --exclude rustpython-venvlauncher --verbose --no-default-features --features stdlib,importlib,encodings,ssl-rustls,jit
- name: Run cargo-llvm-cov with Python snippets.
run: python scripts/cargo-llvm-cov.py
continue-on-error: true
Expand All @@ -39,6 +42,7 @@ jobs:
- name: Prepare code coverage data
run: cargo llvm-cov report --lcov --output-path='codecov.lcov'
- name: Upload to Codecov
if: ${{ github.event_name != 'pull_request' }}
uses: codecov/codecov-action@v5
with:
file: ./codecov.lcov
Expand All @@ -58,6 +62,7 @@ jobs:
env:
RUSTPYTHONPATH: ${{ github.workspace }}/Lib
- name: upload tests data to the website
if: ${{ github.event_name != 'pull_request' }}
env:
SSHKEY: ${{ secrets.ACTIONS_TESTS_DATA_DEPLOY_KEY }}
GITHUB_ACTOR: ${{ github.actor }}
Expand Down Expand Up @@ -94,6 +99,7 @@ jobs:
env:
RUSTPYTHONPATH: ${{ github.workspace }}/Lib
- name: Upload data to the website
if: ${{ github.event_name != 'pull_request' }}
env:
SSHKEY: ${{ secrets.ACTIONS_TESTS_DATA_DEPLOY_KEY }}
GITHUB_ACTOR: ${{ github.actor }}
Expand Down Expand Up @@ -141,7 +147,7 @@ jobs:
- uses: dtolnay/rust-toolchain@stable
- uses: actions/setup-python@v6.1.0
with:
python-version: 3.9
python-version: ${{ env.PYTHON_VERSION }}
- run: cargo install cargo-criterion
- name: build benchmarks
run: cargo build --release --benches
Expand All @@ -162,6 +168,7 @@ jobs:
mv reports/* .
rmdir reports
- name: upload benchmark data to the website
if: ${{ github.event_name != 'pull_request' }}
env:
SSHKEY: ${{ secrets.ACTIONS_TESTS_DATA_DEPLOY_KEY }}
run: |
Expand Down
2 changes: 1 addition & 1 deletion extra_tests/custom_text_test_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def __call__(self, data_list, totals=None):

def get_function_args(func_ref):
try:
return [p for p in inspect.getargspec(func_ref).args if p != "self"]
return [p for p in inspect.getfullargspec(func_ref).args if p != "self"]
except:
return None

Expand Down
2 changes: 1 addition & 1 deletion extra_tests/jsontests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import unittest

from custom_text_test_runner import CustomTextTestRunner as Runner
from test.libregrtest.runtest import findtests
from test.libregrtest.findtests import findtests

testnames = findtests()
# idk why this fixes the hanging, if it does
Expand Down
Loading