Skip to content

Update the concurrent library + Added tests#6673

Merged
youknowone merged 3 commits intoRustPython:mainfrom
terryluan12:update_concurrent
Jan 9, 2026
Merged

Update the concurrent library + Added tests#6673
youknowone merged 3 commits intoRustPython:mainfrom
terryluan12:update_concurrent

Conversation

@terryluan12
Copy link
Contributor

@terryluan12 terryluan12 commented Jan 7, 2026

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 7, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (15)
  • Lib/concurrent/futures/__init__.py is excluded by !Lib/**
  • Lib/concurrent/futures/_base.py is excluded by !Lib/**
  • Lib/concurrent/futures/process.py is excluded by !Lib/**
  • Lib/concurrent/futures/thread.py is excluded by !Lib/**
  • Lib/test/test_concurrent_futures/__init__.py is excluded by !Lib/**
  • Lib/test/test_concurrent_futures/executor.py is excluded by !Lib/**
  • Lib/test/test_concurrent_futures/test_as_completed.py is excluded by !Lib/**
  • Lib/test/test_concurrent_futures/test_deadlock.py is excluded by !Lib/**
  • Lib/test/test_concurrent_futures/test_future.py is excluded by !Lib/**
  • Lib/test/test_concurrent_futures/test_init.py is excluded by !Lib/**
  • Lib/test/test_concurrent_futures/test_process_pool.py is excluded by !Lib/**
  • Lib/test/test_concurrent_futures/test_shutdown.py is excluded by !Lib/**
  • Lib/test/test_concurrent_futures/test_thread_pool.py is excluded by !Lib/**
  • Lib/test/test_concurrent_futures/test_wait.py is excluded by !Lib/**
  • Lib/test/test_concurrent_futures/util.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@terryluan12 terryluan12 marked this pull request as draft January 7, 2026 05:36
@terryluan12 terryluan12 changed the title Update the concurrent library + tests Update the concurrent library + Added tests Jan 7, 2026
ShaharNaveh
ShaharNaveh approved these changes Jan 7, 2026
View reviewed changes
Copy link
Contributor

@ShaharNaveh ShaharNaveh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tysm!

@youknowone
Copy link
Member

youknowone commented Jan 8, 2026

@terryluan12 this is looking done, right?

@terryluan12 terryluan12 marked this pull request as ready for review January 9, 2026 03:22
@terryluan12
Copy link
Contributor Author

terryluan12 commented Jan 9, 2026

@terryluan12 this is looking done, right?

Whoops, yep! Should be good to go!

youknowone
youknowone approved these changes Jan 9, 2026
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@youknowone youknowone merged commit b38cdaa into RustPython:main Jan 9, 2026
13 checks passed
terryluan12 added a commit to terryluan12/RustPython that referenced this pull request Jan 15, 2026
@terryluan12
Update the concurrent library + Added tests (RustPython#6673)
0c0c60b 
* Updated concurrent library

* Added test_concurrent_futures from v3.13.11

* Annotated failing tests in test_concurrent_futures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

@ShaharNaveh ShaharNaveh ShaharNaveh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@terryluan12 @youknowone @ShaharNaveh