Skip to content

Updated the urllib + http libraries + test libraries#6672

Merged
youknowone merged 6 commits into
RustPython:mainfrom
terryluan12:update_urllib_http
Jan 16, 2026
Merged

Updated the urllib + http libraries + test libraries#6672
youknowone merged 6 commits into
RustPython:mainfrom
terryluan12:update_urllib_http

Conversation

@terryluan12

@terryluan12 terryluan12 commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Jan 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (20)
  • Lib/http/__init__.py is excluded by !Lib/**
  • Lib/http/client.py is excluded by !Lib/**
  • Lib/http/cookiejar.py is excluded by !Lib/**
  • Lib/http/server.py is excluded by !Lib/**
  • Lib/test/test_http_cookiejar.py is excluded by !Lib/**
  • Lib/test/test_httplib.py is excluded by !Lib/**
  • Lib/test/test_httpservers.py is excluded by !Lib/**
  • Lib/test/test_logging.py is excluded by !Lib/**
  • Lib/test/test_robotparser.py is excluded by !Lib/**
  • Lib/test/test_ssl.py is excluded by !Lib/**
  • Lib/test/test_urllib.py is excluded by !Lib/**
  • Lib/test/test_urllib2.py is excluded by !Lib/**
  • Lib/test/test_urllib2_localnet.py is excluded by !Lib/**
  • Lib/test/test_urllib2net.py is excluded by !Lib/**
  • Lib/test/test_urllib_response.py is excluded by !Lib/**
  • Lib/test/test_wsgiref.py is excluded by !Lib/**
  • Lib/urllib/error.py is excluded by !Lib/**
  • Lib/urllib/parse.py is excluded by !Lib/**
  • Lib/urllib/request.py is excluded by !Lib/**
  • Lib/urllib/robotparser.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@terryluan12 terryluan12 changed the title Updated the urllib + http libraries Updated the urllib + http libraries + test libraries Jan 7, 2026
@terryluan12 terryluan12 changed the title Updated the urllib + http libraries + test libraries Updated the urllib + http libraries + test libraries + test_contextlib_async.py Jan 7, 2026
@terryluan12 terryluan12 marked this pull request as draft January 7, 2026 02:22
youknowone
youknowone reviewed Jan 7, 2026
View reviewed changes
Comment thread Lib/enum.py Outdated
Comment on lines +1760 to +1761
# TODO: RUSTPYTHON; Currently, __new__ is not treated specially in __dict__
# new_member = __new__.__func__

@youknowone youknowone Jan 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens without this patch?

@terryluan12 terryluan12 Jan 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! That error was why I added #6658. Now that it's resolved, it should be good to uncomment. I'll give it a shot after I finish testing asyncio

@terryluan12 terryluan12 force-pushed the update_urllib_http branch 2 times, most recently from aa54aa7 to 86edf1d Compare January 7, 2026 05:59
ShaharNaveh
ShaharNaveh reviewed Jan 7, 2026
View reviewed changes
Comment thread Lib/test/test_contextlib_async.py

@ShaharNaveh ShaharNaveh Jan 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changes of this file can be in their own PR

@terryluan12 terryluan12 force-pushed the update_urllib_http branch 2 times, most recently from ac5387b to b44d087 Compare January 10, 2026 07:29
@terryluan12 terryluan12 changed the title Updated the urllib + http libraries + test libraries + test_contextlib_async.py Updated the urllib + http libraries + test libraries Jan 10, 2026
@github-actions

github-actions Bot commented Jan 10, 2026

Copy link
Copy Markdown
Contributor

Code has been automatically formatted

The code in this PR has been formatted using cargo fmt --all.
Please pull the latest changes before pushing again:

git pull origin update_urllib_http

fanninpm
fanninpm reviewed Jan 11, 2026
View reviewed changes

@fanninpm fanninpm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to these in-line comments, I was wondering if the tests currently marked with this:

    @unittest.skipIf(os.name == 'nt', 'TODO: RUSTPYTHON; ValueError: illegal environment variable name')

…could be replaced with this:

    @unittest.expectedFailureIfWindows('TODO: RUSTPYTHON; ValueError: illegal environment variable name')

Comment thread Lib/test/test_http_cookiejar.py Outdated
Comment thread Lib/test/test_httpservers.py Outdated
Comment thread Lib/test/test_httpservers.py Outdated
Comment thread Lib/test/test_urllib2_localnet.py Outdated
@terryluan12 terryluan12 force-pushed the update_urllib_http branch 3 times, most recently from f36bb4c to d1c7bc3 Compare January 16, 2026 01:57
@terryluan12 terryluan12 marked this pull request as ready for review January 16, 2026 04:48
youknowone
youknowone approved these changes Jan 16, 2026
View reviewed changes

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! 👍

Comment thread Lib/test/test_ssl.py
else:
s.close()

@unittest.expectedFailure # TODO: RUSTPYTHON

@youknowone youknowone Jan 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is interesting that this update fixes a lot of other tests but broken this one.

@youknowone youknowone merged commit 4cb3b9d into RustPython:main Jan 16, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fanninpm fanninpm fanninpm left review comments

@ShaharNaveh ShaharNaveh ShaharNaveh left review comments

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@terryluan12 @youknowone @fanninpm @ShaharNaveh