Skip to content

Update pty + tty + associated libraries - v3.13.10#6630

Merged
youknowone merged 9 commits intoRustPython:mainfrom
terryluan12:update_pty_tty
Jan 5, 2026
Merged

Update pty + tty + associated libraries - v3.13.10#6630
youknowone merged 9 commits intoRustPython:mainfrom
terryluan12:update_pty_tty

Conversation

@terryluan12
Copy link
Contributor

@terryluan12 terryluan12 commented Jan 3, 2026 •
edited by youknowone
Loading

close #5738

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 3, 2026 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (5)
  • Lib/pty.py is excluded by !Lib/**
  • Lib/test/test_builtin.py is excluded by !Lib/**
  • Lib/test/test_pty.py is excluded by !Lib/**
  • Lib/test/test_tty.py is excluded by !Lib/**
  • Lib/tty.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@terryluan12 terryluan12 mentioned this pull request Jan 3, 2026
Closed
youknowone
youknowone reviewed Jan 4, 2026
View reviewed changes
youknowone
youknowone requested changes Jan 5, 2026
View reviewed changes
youknowone
youknowone approved these changes Jan 5, 2026
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, now i got what you meant. It is not failure during test, but during setup

@youknowone youknowone merged commit 75838e5 into RustPython:main Jan 5, 2026
13 checks passed
terryluan12 added a commit to terryluan12/RustPython that referenced this pull request Jan 5, 2026
@terryluan12
Update pty + tty + associated libraries - v3.13.10 (RustPython#6630)
d35894c 
* Update tty + added the test from v3.13.10

* Updated pty.py + test
@terryluan12 terryluan12 deleted the update_pty_tty branch January 5, 2026 19:06
terryluan12 added a commit to terryluan12/RustPython that referenced this pull request Jan 15, 2026
@terryluan12
Update pty + tty + associated libraries - v3.13.10 (RustPython#6630)
6e7877d 
* Update tty + added the test from v3.13.10

* Updated pty.py + test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@terryluan12 @youknowone