Skip to content

Update the fractions and ftplib libraries + associated tests - v.3.13.10#6607

Merged
youknowone merged 3 commits intoRustPython:mainfrom
terryluan12:update_fractions_ftplib
Jan 2, 2026
Merged

Update the fractions and ftplib libraries + associated tests - v.3.13.10#6607
youknowone merged 3 commits intoRustPython:mainfrom
terryluan12:update_fractions_ftplib

Conversation

@terryluan12
Copy link
Contributor

@terryluan12 terryluan12 commented Dec 31, 2025

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 31, 2025 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (4)
  • Lib/fractions.py is excluded by !Lib/**
  • Lib/ftplib.py is excluded by !Lib/**
  • Lib/test/test_fractions.py is excluded by !Lib/**
  • Lib/test/test_ftplib.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@terryluan12 terryluan12 mentioned this pull request Dec 31, 2025
Closed
@terryluan12 terryluan12 changed the title Update fractions the ftplib and fractions libraries + associated tests Update the fractions and ftplib libraries + associated tests Dec 31, 2025
@terryluan12 terryluan12 changed the title Update the fractions and ftplib libraries + associated tests Update the fractions and ftplib libraries + associated tests - v.3.13.10 Dec 31, 2025
@youknowone
Copy link
Member

youknowone commented Jan 1, 2026

This one is looking good. could you rebase this to exclude previously merged importlib?

@terryluan12 terryluan12 force-pushed the update_fractions_ftplib branch from 12bb677 to 26cc13c Compare January 2, 2026 21:51
@terryluan12
Copy link
Contributor Author

terryluan12 commented Jan 2, 2026

Yup, just done! Thanks @youknowone, and hope you had a good New Years!

@fanninpm fanninpm mentioned this pull request Jan 2, 2026
Closed
youknowone
youknowone approved these changes Jan 2, 2026
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! and happy new year!

@youknowone youknowone merged commit 5ae75a6 into RustPython:main Jan 2, 2026
13 checks passed
@terryluan12 terryluan12 deleted the update_fractions_ftplib branch January 5, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@terryluan12 @youknowone