Handle unions with GenericAlias subclasses without TypeError by Copilot · Pull Request #6540 · RustPython/RustPython

Copilot · 2025-12-26T07:41:00Z

Treat subclasses of GenericAlias/UnionType as unionable; move Callable union snippet into stdlib_typing
Make union dedup robust to comparison errors
Enable union parameter substitution test
Run test_typing, test_types, and clippy on core crates

Original prompt

This section details on the original issue you should resolve

<issue_title>TypeError: '|' not supported between instances of 'type' and '_CallableGenericAlias'</issue_title>
<issue_description>I'm trying to use pytest to have full test coverage in xonsh shell

rustpython -V
# Python 3.13.0alpha (heads/master:40acd5529
rustpython -m pip install pytest
cd /tmp
git clone https://github.com/xonsh/xonsh
cd xonsh
pytest

Traceback (most recent call last):
  File "/Users/pc/.local/bin/pytest", line 3, in <module>
    from pytest import console_main
  File "/Users/pc/.local/lib/rustpython3.13/site-packages/pytest/__init__.py", line 8, in <module>
    from _pytest._code import ExceptionInfo
  File "/Users/pc/.local/lib/rustpython3.13/site-packages/_pytest/_code/__init__.py", line 5, in <module>
    from .code import Code
  File "/Users/pc/.local/lib/rustpython3.13/site-packages/_pytest/_code/code.py", line 862, in <module>
    TracebackFilter: TypeAlias = bool | Callable[[ExceptionInfo[BaseException]], Traceback]
TypeError: '|' not supported between instances of 'type' and '_CallableGenericAlias'
```</issue_description>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

Fixes TypeError: '|' not supported between instances of 'type' and '_CallableGenericAlias' #6538

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

coderabbitai · 2025-12-26T07:41:06Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-12-26T08:27:33Z

Code has been automatically formatted

The code in this PR has been formatted using cargo fmt --all.
Please pull the latest changes before pushing again:

git pull origin copilot/fix-typeerror-in-pytest

youknowone

ensure test_types and test_typing working

youknowone · 2025-12-26T11:38:33Z

+    let Some(_) = module
+        .as_ref()
+        .and_then(|m| m.downcast_ref::<PyStr>())
+        .filter(|m| m.as_str() == TYPING_MODULE)
+    else {
+        return false;
+    };


this is wrong approach

Simplified unionability to allow subclasses of types.GenericAlias/types.UnionType instead of the prior typing-specific check (3b4e565).

youknowone · 2025-12-26T11:39:18Z

test need to be placed in extra_tests/snippets/stdlib_typing.py

Moved the Callable union snippet into extra_tests/snippets/stdlib_typing.py and dropped the standalone file (3b4e565).

Copilot · 2025-12-26T11:53:09Z

ensure test_types and test_typing working

Ran targeted suites after the fixes: test_typing and test_types now pass (3b4e565).

youknowone · 2025-12-26T12:27:13Z

@coderabbitai review

coderabbitai · 2025-12-26T12:27:17Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

youknowone · 2025-12-26T13:38:55Z

@copilot fix clippy

Copilot · 2025-12-26T13:52:38Z

@copilot fix clippy

Clippy is clean now for the core crates; see 1d2b0db.

Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>

Copilot AI assigned Copilot and youknowone Dec 26, 2025

Copilot started work on behalf of youknowone December 26, 2025 07:41

View session

Copilot AI changed the title ~~[WIP] Fix TypeError in pytest compatibility with rustpython~~ Handle unions with typing.Callable aliases without TypeError Dec 26, 2025

Copilot AI requested a review from youknowone December 26, 2025 08:17

Copilot finished work on behalf of youknowone December 26, 2025 08:17

youknowone requested changes Dec 26, 2025

View reviewed changes

Copilot started work on behalf of youknowone December 26, 2025 11:40

View session

Copilot AI changed the title ~~Handle unions with typing.Callable aliases without TypeError~~ Handle unions with GenericAlias subclasses without TypeError Dec 26, 2025

Copilot AI requested a review from youknowone December 26, 2025 11:54

Copilot finished work on behalf of youknowone December 26, 2025 11:54

youknowone marked this pull request as ready for review December 26, 2025 12:27

Copilot started work on behalf of youknowone December 26, 2025 13:39

View session

Copilot finished work on behalf of youknowone December 26, 2025 13:53

Copilot AI and others added 9 commits December 26, 2025 23:42

Initial plan

db4b498

fix: allow unions with typing Callable aliases

199e6dc

Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>

chore: reuse object ref in typing alias check

8540260

Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>

docs: clarify typing alias union helper

9810b58

Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>

refactor: avoid extra clones in typing alias check

7f19d5e

Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>

refactor: simplify typing alias attribute checks

7592129

Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>

chore: tidy module attribute retrieval

d8046eb

Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>

refactor: minimize cloning in typing alias helper

dcaabeb

Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>

chore: drop redundant clone in typing alias helper

e8c0266

Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>

Copilot AI and others added 7 commits December 26, 2025 23:42

refactor: reuse owned object in typing alias helper

105e6b9

Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>

chore: hoist typing module constant and simplify helper

0ccc0cb

Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>

refactor: streamline typing alias attribute checks

ad6fa09

Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>

Auto-format: cargo fmt --all

34e9c40

fix: allow union with GenericAlias subclasses and tidy typing test

e9d5fd5

Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>

chore: satisfy clippy for union dedup

da32326

Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>

fix incompatibility and add TypeAlias check

c2c29c6

youknowone force-pushed the copilot/fix-typeerror-in-pytest branch from 1d2b0db to c2c29c6 Compare December 26, 2025 15:12

youknowone approved these changes Dec 26, 2025

View reviewed changes

youknowone merged commit a7d7f81 into main Dec 26, 2025
13 checks passed

youknowone deleted the copilot/fix-typeerror-in-pytest branch December 26, 2025 16:13

Conversation

Copilot AI commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

github-actions Bot commented Dec 26, 2025

Uh oh!

youknowone left a comment

Choose a reason for hiding this comment

Uh oh!

youknowone Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

youknowone Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Dec 26, 2025

Uh oh!

youknowone commented Dec 26, 2025

Uh oh!

coderabbitai Bot commented Dec 26, 2025

Uh oh!

youknowone commented Dec 26, 2025

Uh oh!

Copilot AI commented Dec 26, 2025

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Dec 26, 2025 •

edited

Loading

coderabbitai Bot commented Dec 26, 2025 •

edited

Loading