Skip to content

Implement winapi.GetLongPathName #6525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 1 commit into from
Dec 25, 2025
Merged

Implement winapi.GetLongPathName #6525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Lib/test/test_winapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,6 @@ def test_max_events_waitany(self):


class WinAPITests(unittest.TestCase):
# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_getlongpathname(self):
testfn = pathlib.Path(os.getenv("ProgramFiles")).parents[-1] / "PROGRA~1"
if not os.path.isdir(testfn):
Expand All @@ -128,8 +126,6 @@ def test_getlongpathname(self):
candidates = set(testfn.parent.glob("Progra*"))
self.assertIn(pathlib.Path(actual), candidates)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_getshortpathname(self):
testfn = pathlib.Path(os.getenv("ProgramFiles"))
if not os.path.isdir(testfn):
Expand Down
48 changes: 48 additions & 0 deletions crates/vm/src/stdlib/winapi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,4 +677,52 @@ mod _winapi {

Ok(WinHandle(handle))
}

/// Helper for GetShortPathName and GetLongPathName
fn get_path_name_impl(
path: &PyStrRef,
api_fn: unsafe extern "system" fn(*const u16, *mut u16, u32) -> u32,
vm: &VirtualMachine,
) -> PyResult<PyStrRef> {
use rustpython_common::wtf8::Wtf8Buf;

let path_wide = path.as_wtf8().to_wide_with_nul();

// First call to get required buffer size
let size = unsafe { api_fn(path_wide.as_ptr(), null_mut(), 0) };

if size == 0 {
return Err(vm.new_last_os_error());
}

// Second call to get the actual path
let mut buffer: Vec<u16> = vec![0; size as usize];
let result =
unsafe { api_fn(path_wide.as_ptr(), buffer.as_mut_ptr(), buffer.len() as u32) };

if result == 0 {
return Err(vm.new_last_os_error());
}

// Truncate to actual length (excluding null terminator)
buffer.truncate(result as usize);

// Convert UTF-16 back to WTF-8 (handles surrogates properly)
let result_str = Wtf8Buf::from_wide(&buffer);
Ok(vm.ctx.new_str(result_str))
}

/// GetShortPathName - Return the short version of the provided path.
#[pyfunction]
fn GetShortPathName(path: PyStrRef, vm: &VirtualMachine) -> PyResult<PyStrRef> {
use windows_sys::Win32::Storage::FileSystem::GetShortPathNameW;
get_path_name_impl(&path, GetShortPathNameW, vm)
}

/// GetLongPathName - Return the long version of the provided path.
#[pyfunction]
fn GetLongPathName(path: PyStrRef, vm: &VirtualMachine) -> PyResult<PyStrRef> {
use windows_sys::Win32::Storage::FileSystem::GetLongPathNameW;
get_path_name_impl(&path, GetLongPathNameW, vm)
}
}
Loading