Skip to content

Update shelve.py from 3.13.11#6483

Merged
youknowone merged 2 commits intoRustPython:mainfrom
ShaharNaveh:update-test-shelve
Jan 1, 2026
Merged

Update shelve.py from 3.13.11#6483
youknowone merged 2 commits intoRustPython:mainfrom
ShaharNaveh:update-test-shelve

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Dec 24, 2025

related to #6410

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 24, 2025 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone
Copy link
Member

youknowone commented Dec 31, 2025

@ShaharNaveh did you also update shelve.py?

@ShaharNaveh
Copy link
Contributor Author

ShaharNaveh commented Dec 31, 2025

@ShaharNaveh did you also update shelve.py?

I've tried not to. but I'll try to update it as well

@ShaharNaveh ShaharNaveh changed the title Update test_shelve.py from 3.13.11 Update shelve.py from 3.13.11 Dec 31, 2025
@youknowone
Copy link
Member

youknowone commented Dec 31, 2025

Lib/X.py and Lib/test/test_X.py is pair. they are usually intended to be updated at the same time

@youknowone youknowone mentioned this pull request Jan 1, 2026
Merged
This was referenced Jan 1, 2026
Closed
Merged
@youknowone youknowone mentioned this pull request Jan 1, 2026
Merged
@youknowone youknowone marked this pull request as ready for review January 1, 2026 08:14
@youknowone youknowone merged commit b446dac into RustPython:main Jan 1, 2026
23 of 24 checks passed
@ShaharNaveh
Copy link
Contributor Author

ShaharNaveh commented Jan 1, 2026

Lib/X.py and Lib/test/test_X.py is pair. they are usually intended to be updated at the same time

I'm aware, I've tried to minimize the changes in this PR as my only goal was to update test_shelve.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone