Convert memoryview and slice to Any payload #646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #646 +/- ##
==========================================
+ Coverage 40.81% 41.08% +0.27%
==========================================
Files 76 77 +1
Lines 17345 17525 +180
Branches 4474 4548 +74
==========================================
+ Hits 7079 7201 +122
- Misses 8366 8404 +38
- Partials 1900 1920 +20
Continue to review full report at Codecov.
|
vm/src/obj/objrange.rs
Outdated
| }; | ||
|
|
||
| _ => Err(vm.new_type_error("range indices must be integer or slice".to_string())), | ||
| return Ok(PyObject::new( |
Contributor
There was a problem hiding this comment.
Instead of if-with-a-return, do not use return, but the implement else. This gives less different return paths from the code.
Contributor
Author
There was a problem hiding this comment.
Oops, I went too fast here and got sloppy 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #645 to avoid conflicts.