Skip to content

Add regression test for #4505 #6417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Dec 12, 2025
Merged

Add regression test for #4505 #6417

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91f60a9
Add regression test for #4505
ShaharNaveh Dec 12, 2025
26951d2
Move tests to `builtin_type.py`
ShaharNaveh Dec 12, 2025
ec85b45
Merge remote-tracking branch 'upstream/main' into regr-test-doc-leak
ShaharNaveh Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions extra_tests/snippets/builtin_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import types
from testutils import assert_raises

from testutils import assert_raises

# Spec: https://docs.python.org/2/library/types.html
print(None)
Expand Down Expand Up @@ -111,8 +111,6 @@ class D:
with assert_raises(TypeError):
del int.__qualname__

from testutils import assert_raises
Copy link
Collaborator Author

@ShaharNaveh ShaharNaveh Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also run ruff check --select I in our CI 🤔

Copy link
Member

@youknowone youknowone Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about just put it in auto-format and add some files to blocklist


import platform

if platform.python_implementation() == "RustPython":
Expand Down Expand Up @@ -607,3 +605,24 @@ class A(type):


assert "__dict__" not in A.__dict__


# regression tests for: https://github.com/RustPython/RustPython/issues/4505


def foo():
def inner():
pass


assert foo.__code__.co_names == ()

stmts = """
import blah

def foo():
pass
"""

code = compile(stmts, "<test>", "exec")
assert code.co_names == ("blah", "foo")
Loading