Skip to content

native ExceptionGroup #6358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Dec 9, 2025
Merged

native ExceptionGroup #6358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ebf5d0
native exception group
youknowone Dec 8, 2025
cb878a0
Remove python impl
youknowone Dec 9, 2025
ba9c8e2
Update crates/vm/src/exception_group.rs
youknowone Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Lib/test/test_exception_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ def test_exception_is_not_generic_type(self):
with self.assertRaisesRegex(TypeError, 'Exception'):
Exception[OSError]

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_exception_group_is_generic_type(self):
E = OSError
self.assertIsInstance(ExceptionGroup[E], types.GenericAlias)
Expand Down Expand Up @@ -810,8 +808,6 @@ def test_split_copies_notes(self):
self.assertEqual(match.__notes__, orig_notes + ["match"])
self.assertEqual(rest.__notes__, orig_notes + ["rest"])

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_split_does_not_copy_non_sequence_notes(self):
# __notes__ should be a sequence, which is shallow copied.
# If it is not a sequence, the split parts don't get any notes.
Expand All @@ -821,8 +817,6 @@ def test_split_does_not_copy_non_sequence_notes(self):
self.assertFalse(hasattr(match, '__notes__'))
self.assertFalse(hasattr(rest, '__notes__'))

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_drive_invalid_return_value(self):
class MyEg(ExceptionGroup):
def derive(self, excs):
Expand Down
2 changes: 0 additions & 2 deletions Lib/test/test_socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5360,8 +5360,6 @@ def test_create_connection(self):
expected_errnos = socket_helper.get_socket_conn_refused_errs()
self.assertIn(cm.exception.errno, expected_errnos)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_create_connection_all_errors(self):
port = socket_helper.find_unused_port()
try:
Expand Down
330 changes: 0 additions & 330 deletions crates/vm/Lib/python_builtins/_py_exceptiongroup.py
View file
Open in desktop

This file was deleted.

Loading
Loading