Skip to content

fix(sqlite): Raise ProgrammingError when operating on a closed cursor #6339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 1 commit into from
Dec 7, 2025
Merged

fix(sqlite): Raise ProgrammingError when operating on a closed cursor #6339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Lib/test/test_sqlite3/test_dbapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1735,8 +1735,6 @@ def test_closed_call(self):
con()

class ClosedCurTests(unittest.TestCase):
# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_closed(self):
con = sqlite.connect(":memory:")
cur = con.cursor()
Expand Down
16 changes: 9 additions & 7 deletions crates/stdlib/src/sqlite.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1771,6 +1771,8 @@ mod _sqlite {
script: PyUtf8StrRef,
vm: &VirtualMachine,
) -> PyResult<PyRef<Self>> {
let _ = zelf.clone().inner(vm)?;

let db = zelf.connection.db_lock(vm)?;

db.sql_limit(script.byte_len(), vm)?;
Expand Down Expand Up @@ -1829,19 +1831,19 @@ mod _sqlite {
fn close(&self, vm: &VirtualMachine) -> PyResult<()> {
// Check if __init__ was called
let mut guard = self.inner.lock();
if guard.is_none() {

let Some(inner) = guard.as_mut() else {
return Err(new_programming_error(
vm,
"Base Cursor.__init__ not called.".to_owned(),
));
}
};

if let Some(inner) = guard.as_mut() {
if let Some(stmt) = &inner.statement {
stmt.lock().reset();
}
inner.closed = true;
if let Some(stmt) = &inner.statement {
stmt.lock().reset();
}
inner.closed = true;

Ok(())
}

Expand Down
Loading