Can you please put the link in the PR here? it will be easier to access rather than going to git blame -> PR -> links

Could you please clarify the context? I am currently unable to understand why it's required.

Not required. Just my personal preference

This isn’t the official stance of our project, but I’d like to share my personal view on the matter.

If the behavior is something that’s common sense and easily predictable, I don’t think we need to attach a reference. In my opinion, this change falls into that category. Before adding this code, it might have been unclear whether such a check was necessary, but once the code is added, it becomes obvious that it is.

Some behaviors are hard to infer from the code alone. In those cases, having a reference linked is helpful. Depending on the situation, when pointing to the exact code is useful, we link specific line numbers; when it’s more important to refer to the conceptual location, we just mention the function name instead.

⚠️ Potential issue | 🟠 Major

#!/bin/bash
# Description: Search for all Blob methods to verify consistent closed-connection handling

echo "=== Blob methods in the file ==="
ast-grep --pattern $'impl Blob {
  $$$
  fn $METHOD($$$) $$$
  $$$
}'

echo -e "\n=== Checking which methods call connection.db_lock or check connection state ==="
rg -n -A5 -B2 'impl Blob' crates/stdlib/src/sqlite.rs | rg -A5 'fn (write|tell|seek|__enter__|__exit__|subscript|ass_subscript)'

#!/bin/bash
# Description: Extract Blob impl block and examine all methods

echo "=== Finding impl Blob block ==="
rg -n 'impl Blob' crates/stdlib/src/sqlite.rs -A 300

echo -e "\n=== Counting methods in Blob impl ==="
rg -n 'fn ' crates/stdlib/src/sqlite.rs | grep -A1 -B1 'Blob'

#!/bin/bash
# Search for CPython's blob.c file content from GitHub

echo "=== Searching for CPython blob.c on GitHub ==="
curl -s https://raw.githubusercontent.com/python/cpython/main/Modules/_sqlite/blob.c | head -400

Add closed-connection check to other blob methods for consistency with CPython behavior.

CPython's check_blob() function checks connection status on ALL blob operations (read, write, seek, tell, enter, exit). The Rust implementation only added this check to read(). The following methods should include the same check before calling self.inner(vm)?:

• write() (line 2207)
• tell() (line 2222)
• seek() (line 2227)
• __enter__() (line 2261)
• __exit__() (line 2267)
• subscript() (line 2313)
• ass_subscript() (line 2350)

Without these checks, operations on other methods could fail with unclear errors when the connection is closed, unlike CPython which provides a consistent error message.

In crates/stdlib/src/sqlite.rs around lines 2176-2360 (affecting the methods
at/near lines 2207, 2222, 2227, 2261, 2267, 2313, 2350), add the same
closed-connection guard used at lines 2176-2181 to each listed blob method:
before calling self.inner(vm)? in write(), tell(), seek(), __enter__(),
__exit__(), subscript(), and ass_subscript(), check if
self.connection.is_closed() and if so return Err(new_programming_error(vm,
"Cannot operate on a closed database".to_owned())); this ensures consistent
CPython-like error messages for all blob operations when the connection is
closed.

@ever0de How do you think about this comment?

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

@youknowone Can I handle this in a separate issue?