Skip to content

Move derive -> crates/derive #6264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowone merged 8 commits into from
Nov 15, 2025
Merged

Move derive -> crates/derive #6264

youknowone merged 8 commits into from
Nov 15, 2025

Conversation

@ShaharNaveh
Copy link
Collaborator

@ShaharNaveh ShaharNaveh commented Nov 14, 2025 •
edited by coderabbitai bot
Loading

ref: #6214

Summary by CodeRabbit

  • Chores
    • Reorganized internal package layout and adjusted internal dependency references to reflect the new layout.
    • Removed an internal workspace member that is no longer part of the build configuration.
    • No user-facing changes or functionality impacts.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 14, 2025 •
edited
Loading

Walkthrough

Workspace configuration updated: the derive crate was removed from the top-level workspace members and the rustpython-derive workspace dependency path changed from "derive" to "crates/derive", version unchanged.

Changes

Cohort / File(s) Change Summary
Workspace manifest
Cargo.toml		 Removed derive from [workspace] members; changed rustpython-derive dependency path from path = "derive" to path = "crates/derive" (version remains 0.4.0).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Small, localized manifest edits; verify workspace member removal and dependency path update.
  • Check CI/workspace build and any references to the old derive path in scripts or docs.

Possibly related PRs

Suggested reviewers

  • youknowone

Poem

🐰 Hop, hop — a crate on the move,
From root to crates it finds its groove,
Paths adjusted, tidy and neat,
Build tree humming with tiny feet. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title directly and accurately describes the main change: moving the 'derive' crate from the root directory to 'crates/derive'.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a8954e4 and 1ce2f09.

📒 Files selected for processing (1)
  • Cargo.toml (1 hunks)
🔇 Additional comments (1)
Cargo.toml (1)

143-143: Derive crate relocation is complete and correctly configured.

All verification checks passed:

  • ✓ Crate successfully moved to crates/derive/ with valid metadata
  • ✓ Stale derive/ directory removed
  • ✓ No remaining references to old path = "derive" in manifests
  • ✓ Cargo.lock synchronized and consistent
  • ✓ Workspace dependency path correctly updated on line 143
  • ✓ Glob pattern crates/* properly captures relocated crate

The change integrates correctly with the broader workspace reorganization.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ShaharNaveh ShaharNaveh mentioned this pull request Nov 14, 2025
Open
16 tasks
@fanninpm
Copy link
Contributor

fanninpm commented Nov 14, 2025

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 14, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai[bot]
coderabbitai bot reviewed Nov 14, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 609d99f and dc7df08.

📒 Files selected for processing (2)
  • Cargo.toml (1 hunks)
  • jit/Cargo.toml (1 hunks)
🔇 Additional comments (1)
Cargo.toml (1)

154-154: Migration verified—no issues remain.

The crate relocation is complete and correct:

  • ✓ crates/derive/Cargo.toml exists with valid structure
  • ✓ No stale path = "derive" references found
  • ✓ All consumers (jit, pylib, stdlib, vm) use workspace = true
  • ✓ Root Cargo.toml line 154 correctly references path = "crates/derive"
  • ✓ Workspace glob pattern crates/* captures the moved crate
  • ✓ derive-impl (separate crate at root level) correctly remains an explicit member

@youknowone youknowone merged commit 8715ae7 into RustPython:main Nov 15, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShaharNaveh @fanninpm @youknowone