Skip to content

stdlib(sqlite): Raise ProgrammingError in closed Blob context manager #6041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 1 commit into from
Jul 27, 2025
Merged

stdlib(sqlite): Raise ProgrammingError in closed Blob context manager #6041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Lib/test/test_sqlite3/test_dbapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1452,8 +1452,6 @@ class DummyException(Exception):
raise DummyException("reraised")


# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_blob_closed(self):
with memory_database() as cx:
cx.execute("create table test(b blob)")
Expand Down
11 changes: 7 additions & 4 deletions stdlib/src/sqlite.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2145,13 +2145,16 @@ mod _sqlite {
}

#[pymethod]
fn __enter__(zelf: PyRef<Self>) -> PyRef<Self> {
zelf
fn __enter__(zelf: PyRef<Self>, vm: &VirtualMachine) -> PyResult<PyRef<Self>> {
let _ = zelf.inner(vm)?;
Ok(zelf)
}

#[pymethod]
fn __exit__(&self, _args: FuncArgs) {
self.close()
fn __exit__(&self, _args: FuncArgs, vm: &VirtualMachine) -> PyResult<()> {
let _ = self.inner(vm)?;
self.close();
Ok(())
}

fn inner(&self, vm: &VirtualMachine) -> PyResult<PyMappedMutexGuard<'_, BlobInner>> {
Expand Down
Loading