Skip to content

stdlib(sqlite3): Raise ProgrammingError for missing named parameter #6036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 2 commits into from
Jul 25, 2025
Merged

stdlib(sqlite3): Raise ProgrammingError for missing named parameter #6036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1706b00
stdlib(sqlite3): Raise ProgrammingError for missing named parameter
ever0de Jul 25, 2025
203c9d3
clippy
ever0de Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Lib/test/test_sqlite3/test_dbapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -908,8 +908,6 @@ def __missing__(self, key):
row = self.cu.fetchone()
self.assertEqual(row[0], "foo")

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_execute_dict_mapping_too_little_args(self):
self.cu.execute("insert into test(name) values ('foo')")
with self.assertRaises(sqlite.ProgrammingError):
Expand Down
10 changes: 9 additions & 1 deletion stdlib/src/sqlite.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2725,7 +2725,15 @@ mod _sqlite {
let name = unsafe { name.add(1) };
let name = ptr_to_str(name, vm)?;

let val = dict.get_item(name, vm)?;
let val = match dict.get_item_opt(name, vm)? {
Some(val) => val,
None => {
return Err(new_programming_error(
vm,
format!("You did not supply a value for binding parameter :{name}.",),
));
}
};

self.bind_parameter(i, &val, vm)?;
}
Expand Down
Loading