Skip to content

Update ast.py from 3.13.5#6006

Merged
youknowone merged 2 commits intoRustPython:mainfrom
ShaharNaveh:update-ast
Jul 20, 2025
Merged

Update ast.py from 3.13.5#6006
youknowone merged 2 commits intoRustPython:mainfrom
ShaharNaveh:update-ast

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Jul 20, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Introduced two new module-level attributes, PyCF_OPTIMIZED_AST and PyCF_TYPE_COMMENTS, in the _ast module.

  • Style

    • Updated the wording of a type error message for invalid types in constants to improve clarity.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 20, 2025 •
edited
Loading

Walkthrough

Two new compile flags, PY_CF_OPTIMIZED_AST and PY_CF_TYPE_COMMENTS, were introduced and integrated into both the Rust and Python layers of the AST module. The compile flags mask was updated to include these flags. Additionally, a minor wording change was made to an error message in the constant literal handling.

Changes

File(s) Change Summary
vm/src/stdlib/ast.rs Added PY_CF_OPTIMIZED_AST and PY_CF_TYPE_COMMENTS constants; updated PY_COMPILE_FLAGS_MASK.
vm/src/stdlib/ast/python.rs Imported new flags and exposed them as Python module attributes (PyCF_OPTIMIZED_AST, PyCF_TYPE_COMMENTS).
vm/src/stdlib/ast/constant.rs Changed error message wording for invalid constant type in ConstantLiteral::ast_from_object.

Poem

Two flags hop in, with numbers so bright,
Now Python and Rust share compile-time delight.
Error words polished, a message anew—
The AST garden grows with something fresh too.
🐇✨ Flags and constants, all in a row,
CodeRabbit’s burrow continues to grow!

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4e0c1aa and 3dc2c9d.

⛔ Files ignored due to path filters (6)
  • Lib/ast.py is excluded by !Lib/**
  • Lib/test/test_ast.py is excluded by !Lib/**
  • Lib/test/test_ast/__init__.py is excluded by !Lib/**
  • Lib/test/test_ast/snippets.py is excluded by !Lib/**
  • Lib/test/test_ast/test_ast.py is excluded by !Lib/**
  • Lib/test/test_ast/utils.py is excluded by !Lib/**
📒 Files selected for processing (3)
  • vm/src/stdlib/ast.rs (2 hunks)
  • vm/src/stdlib/ast/constant.rs (1 hunks)
  • vm/src/stdlib/ast/python.rs (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.rs

Instructions used from:

Sources:
📄 CodeRabbit Inference Engine

  • .github/copilot-instructions.md
🧠 Learnings (3)
📓 Common learnings 
Learnt from: moreal
PR: RustPython/RustPython#5847
File: vm/src/stdlib/stat.rs:547-567
Timestamp: 2025-06-27T14:47:28.810Z
Learning: In RustPython's stat module implementation, platform-specific constants like SF_SUPPORTED and SF_SYNTHETIC should be conditionally declared only for the platforms where they're available (e.g., macOS), following CPython's approach of optional declaration using #ifdef checks rather than providing fallback values for other platforms.

Learnt from: moreal
PR: RustPython/RustPython#5847
File: vm/src/stdlib/stat.rs:547-567
Timestamp: 2025-06-27T14:47:28.810Z
Learning: In RustPython's stat module implementation, platform-specific constants like SF_SUPPORTED and SF_SYNTHETIC should be conditionally declared only for the platforms where they're available (e.g., macOS), following CPython's approach of optional declaration rather than providing fallback values for other platforms.

Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-19T03:16:56.511Z
Learning: Applies to Lib/test/**/*.py : When tests fail due to unsupported syntax, keep the test as `@unittest.expectedFailure`, document that it requires PEP 695 support, and focus on tests that can be fixed through Rust code changes only
vm/src/stdlib/ast/python.rs (5) 
Learnt from: moreal
PR: RustPython/RustPython#5847
File: vm/src/stdlib/stat.rs:547-567
Timestamp: 2025-06-27T14:47:28.810Z
Learning: In RustPython's stat module implementation, platform-specific constants like SF_SUPPORTED and SF_SYNTHETIC should be conditionally declared only for the platforms where they're available (e.g., macOS), following CPython's approach of optional declaration using #ifdef checks rather than providing fallback values for other platforms.

Learnt from: moreal
PR: RustPython/RustPython#5847
File: vm/src/stdlib/stat.rs:547-567
Timestamp: 2025-06-27T14:47:28.810Z
Learning: In RustPython's stat module implementation, platform-specific constants like SF_SUPPORTED and SF_SYNTHETIC should be conditionally declared only for the platforms where they're available (e.g., macOS), following CPython's approach of optional declaration rather than providing fallback values for other platforms.

Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-19T03:16:56.511Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust

Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-19T03:16:56.511Z
Learning: Applies to Lib/**/*.py : Minimize modifications to CPython standard library files in `Lib/`

Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-19T03:16:56.511Z
Learning: Applies to Lib/test/**/*.py : When tests fail due to unsupported syntax, keep the test as `@unittest.expectedFailure`, document that it requires PEP 695 support, and focus on tests that can be fixed through Rust code changes only
vm/src/stdlib/ast.rs (4) 
Learnt from: moreal
PR: RustPython/RustPython#5847
File: vm/src/stdlib/stat.rs:547-567
Timestamp: 2025-06-27T14:47:28.810Z
Learning: In RustPython's stat module implementation, platform-specific constants like SF_SUPPORTED and SF_SYNTHETIC should be conditionally declared only for the platforms where they're available (e.g., macOS), following CPython's approach of optional declaration using #ifdef checks rather than providing fallback values for other platforms.

Learnt from: moreal
PR: RustPython/RustPython#5847
File: vm/src/stdlib/stat.rs:547-567
Timestamp: 2025-06-27T14:47:28.810Z
Learning: In RustPython's stat module implementation, platform-specific constants like SF_SUPPORTED and SF_SYNTHETIC should be conditionally declared only for the platforms where they're available (e.g., macOS), following CPython's approach of optional declaration rather than providing fallback values for other platforms.

Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-19T03:16:56.511Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust

Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-19T03:16:56.511Z
Learning: Applies to Lib/test/**/*.py : When tests fail due to unsupported syntax, keep the test as `@unittest.expectedFailure`, document that it requires PEP 695 support, and focus on tests that can be fixed through Rust code changes only
🔇 Additional comments (5)
vm/src/stdlib/ast.rs (2)

301-302: LGTM! New compile flags correctly defined.

The new compile flags PY_CF_OPTIMIZED_AST and PY_CF_TYPE_COMMENTS are properly defined with correct values that match CPython 3.13.5. The combination of 0x8000 | PY_COMPILE_FLAG_AST_ONLY for optimized AST is correct.

324-325: LGTM! Compile flags mask properly updated.

The new compile flags are correctly included in the PY_COMPILE_FLAGS_MASK, ensuring they are recognized by the compilation system.

vm/src/stdlib/ast/python.rs (2)

1-1: LGTM! Import statement correctly updated.

The new compile flag constants are properly imported from the parent module.

58-62: LGTM! Python module attributes properly exposed.

The new compile flags are correctly exposed as Python module attributes using the pyattr macro, following the same pattern as the existing PyCF_ONLY_AST attribute. This ensures the flags are accessible from Python code.

vm/src/stdlib/ast/constant.rs (1)

238-238: LGTM! Error message wording improved.

The change from "invalid type in Constant" to "got an invalid type in Constant" makes the error message more natural and readable, aligning with typical Python error message patterns.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ShaharNaveh ShaharNaveh marked this pull request as ready for review July 20, 2025 09:28
youknowone
youknowone approved these changes Jul 20, 2025
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowone youknowone merged commit 8177525 into RustPython:main Jul 20, 2025
12 checks passed
@ShaharNaveh ShaharNaveh deleted the update-ast branch July 20, 2025 09:46
@youknowone youknowone mentioned this pull request Dec 4, 2025
Closed
This was referenced Feb 2, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone