Skip to content

Update compileall from 3.13.5#5914

Merged
youknowone merged 9 commits intoRustPython:mainfrom
ShaharNaveh:update-compileall
Jul 9, 2025
Merged

Update compileall from 3.13.5#5914
youknowone merged 9 commits intoRustPython:mainfrom
ShaharNaveh:update-compileall

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Jul 8, 2025 •
edited by youknowone
Loading

closes #5199

@gemini-code-assist
Copy link

gemini-code-assist bot commented Jul 8, 2025

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 8, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (4)
  • Lib/compileall.py is excluded by !Lib/**
  • Lib/test/support/__init__.py is excluded by !Lib/**
  • Lib/test/support/os_helper.py is excluded by !Lib/**
  • Lib/test/test_compileall.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ShaharNaveh
Copy link
Contributor Author

ShaharNaveh commented Jul 9, 2025

@youknowone It constantly hangs on windows, how can I know which tests causes that?
Also, would you be interested in a PR to set a timeout for the CI, I think it's safe to say that if a job ran for more than an hour it failed

@youknowone
Copy link
Member

youknowone commented Jul 9, 2025

No idea by CI result. Do you have a windows machine? Then it will be easier to check.

The previous trial of this test was #5199

Timeout setup for CI is a good idea. Windows test usually finish in 40mins. Other tests in 30mins.

@ShaharNaveh ShaharNaveh mentioned this pull request Jul 9, 2025
Closed
@ShaharNaveh
Copy link
Contributor Author

ShaharNaveh commented Jul 9, 2025 •
edited
Loading

No idea by CI result. Do you have a windows machine? Then it will be easier to check.

I don't:/
I tried to search for a flag that will make the unittests to display which test it will run (before actually running it) like pytest does it, but I couldn't find anything:/

The previous trial of this test was #5199

ty:)
I looked at what that PR tried to do, I copied some parts of it hopefully it will pass now 🤞

Timeout setup for CI is a good idea. Windows test usually finish in 40mins. Other tests in 30mins.

I've opened an issue on it, I think it's a good first issue

youknowone
youknowone approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@youknowone youknowone merged commit cbd9b30 into RustPython:main Jul 9, 2025
12 checks passed
@ShaharNaveh ShaharNaveh deleted the update-compileall branch July 10, 2025 09:33
@youknowone youknowone mentioned this pull request Dec 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone